Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 977113003: Rename renderer() to layoutObject(). (Closed)

Created:
5 years, 9 months ago by dsinclair
Modified:
5 years, 9 months ago
CC:
aandrey+blink_chromium.org, aboxhall, darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, blink-reviews-style_chromium.org, Rik, caseq+blink_chromium.org, chromiumbugtracker_adobe.com, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, Dominik Röttsches, dshwang, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, Eric Willigers, eustas+blink_chromium.org, feature-media-reviews_chromium.org, f(malita), fs, gavinp+loader_chromium.org, gasubic, groby+blinkspell_chromium.org, gyuyoung.kim_webkit.org, Nate Chapin, jchaffraix+rendering, je_julie(Not used), Justin Novosad, kenneth.christiansen, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), mlamouri+watch-blink_chromium.org, nektarios, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, philipj_slow, rjwright, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, shans, sof, nessy, slimming-paint-reviews_chromium.org, Steve Block, Timothy Loh, tyoshino+watch_chromium.org, vcarbune.chromium, webcomponents-bugzilla_chromium.org, yurys+blink_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Rename renderer() to layoutObject(). This CL renames the renderer() method to layoutObject() it does not attempt to rename any associated variables at this point. These will be done in smaller followups. The renderer() rename has to happen over all layout files at the same time. BUG=462960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191466

Patch Set 1 #

Patch Set 2 : Rebase to master #

Total comments: 32

Patch Set 3 : Rebase to master #

Patch Set 4 : #

Patch Set 5 : Rebase to master #

Patch Set 6 : Rebase to master #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2010 lines, -2009 lines) Patch
M LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/quote-layout-focus-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Animation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/clipboard/DataTransfer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/CharacterData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 12 chunks +16 lines, -16 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 5 6 19 chunks +31 lines, -30 lines 0 comments Download
M Source/core/dom/FirstLetterPseudoElement.cpp View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LayoutTreeBuilder.h View 1 2 3 4 5 6 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/LayoutTreeBuilder.cpp View 1 2 3 4 5 6 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 4 5 12 chunks +20 lines, -20 lines 0 comments Download
M Source/core/dom/NodeLayoutStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRareData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRenderingTraversal.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Position.cpp View 20 chunks +26 lines, -26 lines 0 comments Download
M Source/core/dom/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PseudoElement.cpp View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 1 2 3 4 5 6 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Caret.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/Editor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/HTMLInterchange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InputMethodController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 2 3 4 5 6 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/SimplifyMarkupCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/SplitTextNodeContainingElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 12 chunks +16 lines, -16 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 22 chunks +24 lines, -24 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 2 3 4 5 6 16 chunks +21 lines, -21 lines 0 comments Download
M Source/core/editing/iterators/FullyClippedStateStack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 17 chunks +20 lines, -20 lines 0 comments Download
M Source/core/editing/markup.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/events/MouseRelatedEvent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/Frame.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 12 chunks +22 lines, -22 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/frame/SmartClip.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAreaElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 2 3 4 5 6 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 2 3 4 5 8 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameElement.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 3 4 5 6 13 chunks +18 lines, -18 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 3 4 5 6 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/HTMLLIElement.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 5 6 11 chunks +24 lines, -24 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOListElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 2 3 4 5 6 8 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 3 4 5 6 23 chunks +31 lines, -31 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 3 4 5 6 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 2 3 4 5 6 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/ImageDocument.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/HitRegion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 1 2 3 4 5 6 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/ClearButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MeterShadowElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/ProgressShadowElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 2 3 4 5 6 8 chunks +17 lines, -17 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 2 3 4 5 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/FloatingObjects.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/FloatingObjects.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/HitTestResult.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestResult.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/core/layout/Layer.h View 9 chunks +12 lines, -12 lines 0 comments Download
M Source/core/layout/Layer.cpp View 1 2 3 4 5 75 chunks +132 lines, -132 lines 0 comments Download
M Source/core/layout/LayerClipper.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayerFilterInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayerFilterInfo.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayerScrollableArea.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayerStackingNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayerStackingNode.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 2 3 4 5 6 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 4 5 20 chunks +30 lines, -30 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutCounter.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFileUploadControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutGeometryMap.cpp View 1 2 3 4 5 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutListItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp View 17 chunks +66 lines, -66 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutScrollbar.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutSliderContainer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTableCellTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutText.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutTextControl.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutTheme.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutThemeDefault.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutThemeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 2 3 4 5 7 chunks +11 lines, -11 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/compositing/CompositedLayerMapping.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 46 chunks +74 lines, -74 lines 0 comments Download
M Source/core/layout/compositing/CompositingInputsUpdater.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/layout/compositing/CompositingLayerAssigner.cpp View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/compositing/CompositingReasonFinder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/compositing/CompositingRequirementsUpdater.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/compositing/LayerCompositor.cpp View 1 2 3 4 5 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/layout/line/InlineBox.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/line/InlineBox.cpp View 1 2 3 4 5 10 chunks +29 lines, -29 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 39 chunks +81 lines, -81 lines 0 comments Download
M Source/core/layout/line/InlineTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/InlineTextBox.cpp View 17 chunks +34 lines, -34 lines 0 comments Download
M Source/core/layout/line/LineWidth.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 2 21 chunks +44 lines, -44 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGGradientStop.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGPathData.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextQuery.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/AutoscrollController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/DragController.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 27 chunks +38 lines, -38 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/PrintContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 10 chunks +18 lines, -18 lines 0 comments Download
M Source/core/page/TouchAdjustment.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M Source/core/page/TouchDisambiguation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/paint/BlockFlowPainter.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/EllipsisBoxPainter.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/paint/FileUploadControlPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/FilterPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/FramePainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 15 chunks +33 lines, -33 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 24 chunks +40 lines, -40 lines 0 comments Download
M Source/core/paint/LayerClipRecorder.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/LayerClipRecorderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/LayerPainter.cpp View 1 2 3 4 5 29 chunks +41 lines, -41 lines 0 comments Download
M Source/core/paint/RootInlineBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGInlineFlowBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 11 chunks +18 lines, -18 lines 0 comments Download
M Source/core/paint/SVGRootInlineBoxPainter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/paint/TextPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ViewDisplayListTest.cpp View 13 chunks +36 lines, -36 lines 0 comments Download
M Source/core/paint/ViewPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/PluginOcclusionSupport.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEFloodElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGeometryElement.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLineElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPolyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 2 3 4 5 6 10 chunks +16 lines, -16 lines 0 comments Download
M Source/core/svg/SVGStopElement.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 10 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/accessibility/AXImageMapLink.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 4 12 chunks +18 lines, -18 lines 0 comments Download
M Source/modules/accessibility/AXMediaControls.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 2 3 4 6 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/accessibility/AXScrollView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXSlider.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXSpinButton.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXTableColumn.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ExternalPopupMenuTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/FindInPageCoordinates.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/web/PopupMenuTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SpellCheckerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/TextFinder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/web/WebSurroundingText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 4 5 8 chunks +11 lines, -11 lines 0 comments Download
M Source/web/mac/WebSubstringUtil.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LayoutGeometryMapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorTest.cpp View 1 2 3 4 5 9 chunks +10 lines, -10 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 31 (14 generated)
dsinclair
PTAL. jchaffraix@ for Source/core dmazzoni@ for Source/modules/accessibility mkwst@ for Source/web
5 years, 9 months ago (2015-03-04 16:38:56 UTC) #2
dmazzoni
lgtm not sure if you're waiting for my review on these, please feel free to ...
5 years, 9 months ago (2015-03-04 18:46:18 UTC) #3
leviw_travelin_and_unemployed
https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/Node.h File Source/core/dom/Node.h (right): https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/Node.h#newcode103 Source/core/dom/Node.h:103: void setRenderer(LayoutObject* renderer) { m_renderer = renderer; } Man ...
5 years, 9 months ago (2015-03-04 20:15:31 UTC) #5
dsinclair
https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/Node.h File Source/core/dom/Node.h (right): https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/Node.h#newcode103 Source/core/dom/Node.h:103: void setRenderer(LayoutObject* renderer) { m_renderer = renderer; } On ...
5 years, 9 months ago (2015-03-04 20:37:56 UTC) #6
dsinclair
ping.
5 years, 9 months ago (2015-03-05 14:33:27 UTC) #8
Julien - ping for review
rs lgtm https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/DocumentMarkerController.cpp File Source/core/dom/DocumentMarkerController.cpp (right): https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/DocumentMarkerController.cpp#newcode576 Source/core/dom/DocumentMarkerController.cpp:576: if (LayoutObject* renderer = iterator->key->layoutObject()) s/renderer/layoutObject/ https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/DocumentMarkerController.cpp#newcode606 ...
5 years, 9 months ago (2015-03-05 16:19:16 UTC) #10
dsinclair
On 2015/03/05 at 16:19:16, jchaffraix wrote: > rs lgtm > > https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/DocumentMarkerController.cpp > File Source/core/dom/DocumentMarkerController.cpp ...
5 years, 9 months ago (2015-03-05 16:20:59 UTC) #11
dsinclair
https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/LayoutTreeBuilder.cpp File Source/core/dom/LayoutTreeBuilder.cpp (right): https://codereview.chromium.org/977113003/diff/20001/Source/core/dom/LayoutTreeBuilder.cpp#newcode54 Source/core/dom/LayoutTreeBuilder.cpp:54: m_renderingParent = containerNode->layoutObject(); On 2015/03/05 at 16:19:15, Julien Chaffraix ...
5 years, 9 months ago (2015-03-05 16:40:02 UTC) #12
dsinclair
5 years, 9 months ago (2015-03-05 16:40:05 UTC) #13
dsinclair
+esprehn for source/web
5 years, 9 months ago (2015-03-06 12:58:27 UTC) #15
chrishtr
lgtm
5 years, 9 months ago (2015-03-06 16:18:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977113003/80001
5 years, 9 months ago (2015-03-06 16:27:10 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28433)
5 years, 9 months ago (2015-03-06 16:54:34 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977113003/100001
5 years, 9 months ago (2015-03-06 17:48:00 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/46317)
5 years, 9 months ago (2015-03-06 20:08:08 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977113003/120001
5 years, 9 months ago (2015-03-06 20:50:16 UTC) #30
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 00:31:55 UTC) #31
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191466

Powered by Google App Engine
This is Rietveld 408576698