Rename renderer() to layoutObject().

Source/core/dom/Node.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 81 matching lines @@
 
 enum StyleChangeType {
     NoStyleChange = 0,
     LocalStyleChange = 1 << nodeStyleChangeShift,
     SubtreeStyleChange = 2 << nodeStyleChangeShift,
     NeedsReattachStyleChange = 3 << nodeStyleChangeShift,
 };
 
 class NodeRareDataBase {
 public:
-    LayoutObject* renderer() const { return m_renderer; }
+    LayoutObject* layoutObject() const { return m_renderer; }
     void setRenderer(LayoutObject* renderer) { m_renderer = renderer; }

[leviw_travelin_and_unemployed, 2015/03/04 20:15:30]

Man this is weird :p

[dsinclair, 2015/03/04 20:37:56]

Yea. Doing everything in one CL, I think, would be insane. But, it means we have
wacky intermediate state.

 
 protected:
     NodeRareDataBase(LayoutObject* renderer)
         : m_renderer(renderer)
     { }
 
 protected:
     LayoutObject* m_renderer;
 };
 
@@ skipping 377 matching lines @@
     // Number of DOM 16-bit units contained in node. Note that rendered text length can be different - e.g. because of
     // css-transform:capitalize breaking up precomposed characters and ligatures.
     virtual int maxCharacterOffset() const;
 
     // Whether or not a selection can be started in this object
     virtual bool canStartSelection() const;
 
     // -----------------------------------------------------------------------------
     // Integration with rendering tree
 
-    // As renderer() includes a branch you should avoid calling it repeatedly in hot code paths.
+    // As layoutObject() includes a branch you should avoid calling it repeatedly in hot code paths.
     // Note that if a Node has a renderer, it's parentNode is guaranteed to have one as well.
-    LayoutObject* renderer() const { return hasRareData() ? m_data.m_rareData->renderer() : m_data.m_renderer; };
+    LayoutObject* layoutObject() const { return hasRareData() ? m_data.m_rareData->layoutObject() : m_data.m_renderer; };

[Julien - ping for review, 2015/03/05 16:19:16]

It's weird that layoutObject is in rare data. 

[dsinclair, 2015/03/05 16:40:01]

crbug.com/464392

     void setRenderer(LayoutObject* renderer)
     {
         if (hasRareData())
             m_data.m_rareData->setRenderer(renderer);
         else
             m_data.m_renderer = renderer;
     }
 
     // Use these two methods with caution.
     LayoutBox* layoutBox() const;
@@ skipping 386 matching lines @@
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showNode(const blink::Node*);
 void showTree(const blink::Node*);
 void showNodePath(const blink::Node*);
 #endif
 
 #endif // Node_h