Rename renderer() to layoutObject().

Source/core/html/HTMLTextAreaElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 143 matching lines @@
 }
 
 void HTMLTextAreaElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (name == rowsAttr) {
         int rows = 0;
         if (value.isEmpty() || !parseHTMLInteger(value, rows) || rows <= 0)
             rows = defaultRows;
         if (m_rows != rows) {
             m_rows = rows;
-            if (renderer())
-                renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();
+            if (layoutObject())
+                layoutObject()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();
         }
     } else if (name == colsAttr) {
         int cols = 0;
         if (value.isEmpty() || !parseHTMLInteger(value, cols) || cols <= 0)
             cols = defaultCols;
         if (m_cols != cols) {
             m_cols = cols;
-            if (renderer())
-                renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();
+            if (layoutObject())
+                layoutObject()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();

[Julien - ping for review, 2015/03/05 16:19:16]

It seems like it could be rewritten (as we're touching those lines):

if (LayoutObject layoutObject = this->layoutObject())
    layoutObject->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();

[dsinclair, 2015/03/05 16:40:02]

Done.

         }
     } else if (name == wrapAttr) {
         // The virtual/physical values were a Netscape extension of HTML 3.0, now deprecated.
         // The soft/hard /off values are a recommendation for HTML 4 extension by IE and NS 4.
         WrapMethod wrap;
         if (equalIgnoringCase(value, "physical") || equalIgnoringCase(value, "hard") || equalIgnoringCase(value, "on"))
             wrap = HardWrap;
         else if (equalIgnoringCase(value, "off"))
             wrap = NoWrap;
         else
             wrap = SoftWrap;
         if (wrap != m_wrap) {
             m_wrap = wrap;
-            if (renderer())
-                renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();
+            if (layoutObject())
+                layoutObject()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();

[Julien - ping for review, 2015/03/05 16:19:16]

Ditto.

[dsinclair, 2015/03/05 16:40:01]

Done.

         }
     } else if (name == accesskeyAttr) {
         // ignore for the moment
     } else if (name == maxlengthAttr) {
         setNeedsValidityCheck();
     } else if (name == minlengthAttr) {
         setNeedsValidityCheck();
     } else
         HTMLTextFormControlElement::parseAttribute(name, value);
 }
@@ skipping 46 matching lines @@
         setSelectionRange(0, 0, SelectionHasNoDirection, NotDispatchSelectEvent);
     else
         restoreCachedSelection();
 
     if (document().frame())
         document().frame()->selection().revealSelection();
 }
 
 void HTMLTextAreaElement::defaultEventHandler(Event* event)
 {
-    if (renderer() && (event->isMouseEvent() || event->isDragEvent() || event->hasInterface(EventNames::WheelEvent) || event->type() == EventTypeNames::blur))
+    if (layoutObject() && (event->isMouseEvent() || event->isDragEvent() || event->hasInterface(EventNames::WheelEvent) || event->type() == EventTypeNames::blur))
         forwardEvent(event);
-    else if (renderer() && event->isBeforeTextInsertedEvent())
+    else if (layoutObject() && event->isBeforeTextInsertedEvent())
         handleBeforeTextInsertedEvent(static_cast<BeforeTextInsertedEvent*>(event));
 
     HTMLTextFormControlElement::defaultEventHandler(event);
 }
 
 void HTMLTextAreaElement::handleFocusEvent(Element*, WebFocusType)
 {
     if (LocalFrame* frame = document().frame())
         frame->spellChecker().didBeginEditing(this);
 }
@@ skipping 11 matching lines @@
     // When typing in a textarea, childrenChanged is not called, so we need to force the directionality check.
     calculateAndAdjustDirectionality();
 
     ASSERT(document().isActive());
     document().frameHost()->chrome().client().didChangeValueInTextField(*this);
 }
 
 void HTMLTextAreaElement::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent* event) const
 {
     ASSERT(event);
-    ASSERT(renderer());
+    ASSERT(layoutObject());
     int signedMaxLength = maxLength();
     if (signedMaxLength < 0)
         return;
     unsigned unsignedMaxLength = static_cast<unsigned>(signedMaxLength);
 
     const String& currentValue = innerEditorValue();
     unsigned currentLength = computeLengthForSubmission(currentValue);
     if (currentLength + computeLengthForSubmission(event->text()) < unsignedMaxLength)
         return;
 
@@ skipping 325 matching lines @@
 {
     return true;
 }
 
 bool HTMLTextAreaElement::supportsAutofocus() const
 {
     return true;
 }
 
 }