Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed)

Created:
7 years ago by pneubeck (no reviews)
Modified:
7 years ago
Reviewers:
satorux1
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Remove fake client creation from DBusClients' Create() functions. The DBusClient interfaces shouldn't provide functionality related to testing code (like Stubs/fake implementations). Instead fake clients are now directly created without relying on the static Create() functions. The now unused DBusClientImplementationType argument of the Create() functions could be removed. BUG=275286 R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238330

Patch Set 1 : #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -289 lines) Patch
M chromeos/dbus/bluetooth_adapter_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_adapter_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/bluetooth_agent_manager_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_agent_manager_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/bluetooth_device_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_device_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/bluetooth_input_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_input_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/bluetooth_profile_manager_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/dbus/bluetooth_profile_manager_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/cras_audio_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/cras_audio_client.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chromeos/dbus/cryptohome_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 3 chunks +23 lines, -33 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_adapter_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_agent_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_agent_service_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_input_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_service_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.cc View 4 chunks +42 lines, -36 lines 0 comments Download
M chromeos/dbus/gsm_sms_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/gsm_sms_client.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M chromeos/dbus/gsm_sms_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/image_burner_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/image_burner_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/introspectable_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/modem_messaging_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/nfc_adapter_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/dbus/nfc_adapter_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/nfc_client_unittest.cc View 1 chunk +5 lines, -13 lines 0 comments Download
M chromeos/dbus/nfc_device_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/dbus/nfc_device_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/nfc_manager_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/nfc_manager_client.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chromeos/dbus/nfc_record_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/dbus/nfc_record_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/nfc_tag_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M chromeos/dbus/nfc_tag_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/permission_broker_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/shill_device_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/shill_device_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_device_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_ipconfig_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_manager_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/shill_manager_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_manager_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_profile_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/shill_profile_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_profile_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_service_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/shill_service_client.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/sms_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/system_clock_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/system_clock_client.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pneubeck (no reviews)
ptal
7 years ago (2013-11-29 09:12:38 UTC) #1
satorux1
lgtm. thank you for cleaning up this!
7 years ago (2013-12-03 04:18:02 UTC) #2
pneubeck (no reviews)
7 years ago (2013-12-03 09:59:50 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r238330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698