Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: chromeos/dbus/shill_service_client.cc

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/dbus/shill_service_client.h ('k') | chromeos/dbus/shill_service_client_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/shill_service_client.h" 5 #include "chromeos/dbus/shill_service_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chromeos/dbus/fake_shill_service_client.h"
13 #include "chromeos/dbus/shill_property_changed_observer.h" 12 #include "chromeos/dbus/shill_property_changed_observer.h"
14 #include "chromeos/network/network_event_log.h" 13 #include "chromeos/network/network_event_log.h"
15 #include "dbus/bus.h" 14 #include "dbus/bus.h"
16 #include "dbus/message.h" 15 #include "dbus/message.h"
17 #include "dbus/object_proxy.h" 16 #include "dbus/object_proxy.h"
18 #include "third_party/cros_system_api/dbus/service_constants.h" 17 #include "third_party/cros_system_api/dbus/service_constants.h"
19 18
20 namespace chromeos { 19 namespace chromeos {
21 20
22 namespace { 21 namespace {
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 DISALLOW_COPY_AND_ASSIGN(ShillServiceClientImpl); 265 DISALLOW_COPY_AND_ASSIGN(ShillServiceClientImpl);
267 }; 266 };
268 267
269 } // namespace 268 } // namespace
270 269
271 ShillServiceClient::ShillServiceClient() {} 270 ShillServiceClient::ShillServiceClient() {}
272 271
273 ShillServiceClient::~ShillServiceClient() {} 272 ShillServiceClient::~ShillServiceClient() {}
274 273
275 // static 274 // static
276 ShillServiceClient* ShillServiceClient::Create( 275 ShillServiceClient* ShillServiceClient::Create() {
277 DBusClientImplementationType type) { 276 return new ShillServiceClientImpl();
278 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
279 return new ShillServiceClientImpl();
280 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
281 return new FakeShillServiceClient();
282 } 277 }
283 278
284 } // namespace chromeos 279 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_service_client.h ('k') | chromeos/dbus/shill_service_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698