Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chromeos/dbus/shill_device_client.h

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/dbus/permission_broker_client.h ('k') | chromeos/dbus/shill_device_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_
6 #define CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_ 6 #define CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "chromeos/chromeos_export.h" 12 #include "chromeos/chromeos_export.h"
13 #include "chromeos/dbus/dbus_client.h" 13 #include "chromeos/dbus/dbus_client.h"
14 #include "chromeos/dbus/dbus_client_implementation_type.h"
15 #include "chromeos/dbus/shill_client_helper.h" 14 #include "chromeos/dbus/shill_client_helper.h"
16 15
17 namespace base { 16 namespace base {
18 17
19 class Value; 18 class Value;
20 class DictionaryValue; 19 class DictionaryValue;
21 20
22 } // namespace base 21 } // namespace base
23 22
24 namespace dbus { 23 namespace dbus {
(...skipping 30 matching lines...) Expand all
55 virtual std::string GetDevicePathForType(const std::string& type) = 0; 54 virtual std::string GetDevicePathForType(const std::string& type) = 0;
56 55
57 protected: 56 protected:
58 virtual ~TestInterface() {} 57 virtual ~TestInterface() {}
59 }; 58 };
60 59
61 virtual ~ShillDeviceClient(); 60 virtual ~ShillDeviceClient();
62 61
63 // Factory function, creates a new instance which is owned by the caller. 62 // Factory function, creates a new instance which is owned by the caller.
64 // For normal usage, access the singleton via DBusThreadManager::Get(). 63 // For normal usage, access the singleton via DBusThreadManager::Get().
65 static ShillDeviceClient* Create(DBusClientImplementationType type); 64 static ShillDeviceClient* Create();
66 65
67 // Adds a property changed |observer| for the device at |device_path|. 66 // Adds a property changed |observer| for the device at |device_path|.
68 virtual void AddPropertyChangedObserver( 67 virtual void AddPropertyChangedObserver(
69 const dbus::ObjectPath& device_path, 68 const dbus::ObjectPath& device_path,
70 ShillPropertyChangedObserver* observer) = 0; 69 ShillPropertyChangedObserver* observer) = 0;
71 70
72 // Removes a property changed |observer| for the device at |device_path|. 71 // Removes a property changed |observer| for the device at |device_path|.
73 virtual void RemovePropertyChangedObserver( 72 virtual void RemovePropertyChangedObserver(
74 const dbus::ObjectPath& device_path, 73 const dbus::ObjectPath& device_path,
75 ShillPropertyChangedObserver* observer) = 0; 74 ShillPropertyChangedObserver* observer) = 0;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 // Create() should be used instead. 163 // Create() should be used instead.
165 ShillDeviceClient(); 164 ShillDeviceClient();
166 165
167 private: 166 private:
168 DISALLOW_COPY_AND_ASSIGN(ShillDeviceClient); 167 DISALLOW_COPY_AND_ASSIGN(ShillDeviceClient);
169 }; 168 };
170 169
171 } // namespace chromeos 170 } // namespace chromeos
172 171
173 #endif // CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_ 172 #endif // CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_
OLDNEW
« no previous file with comments | « chromeos/dbus/permission_broker_client.h ('k') | chromeos/dbus/shill_device_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698