Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chromeos/dbus/gsm_sms_client.cc

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/gsm_sms_client.h ('k') | chromeos/dbus/gsm_sms_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/gsm_sms_client.cc
diff --git a/chromeos/dbus/gsm_sms_client.cc b/chromeos/dbus/gsm_sms_client.cc
index 4fead8d32fe06e147c3e52c3d749d2a7bca6a735..0c730f457282ab0fa4eb5f9f3d4decfb98067d2e 100644
--- a/chromeos/dbus/gsm_sms_client.cc
+++ b/chromeos/dbus/gsm_sms_client.cc
@@ -8,15 +8,12 @@
#include <vector>
#include "base/bind.h"
-#include "base/command_line.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
-#include "chromeos/chromeos_switches.h"
-#include "chromeos/dbus/fake_gsm_sms_client.h"
#include "dbus/bus.h"
#include "dbus/message.h"
#include "dbus/object_proxy.h"
@@ -247,16 +244,8 @@ GsmSMSClient::GsmSMSClient() {}
GsmSMSClient::~GsmSMSClient() {}
// static
-GsmSMSClient* GsmSMSClient::Create(DBusClientImplementationType type) {
- if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
- return new GsmSMSClientImpl();
- DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
-
- FakeGsmSMSClient* fake = new FakeGsmSMSClient();
- fake->set_sms_test_message_switch_present(
- CommandLine::ForCurrentProcess()->HasSwitch(
- chromeos::switches::kSmsTestMessages));
- return fake;
+GsmSMSClient* GsmSMSClient::Create() {
+ return new GsmSMSClientImpl();
}
} // namespace chromeos
« no previous file with comments | « chromeos/dbus/gsm_sms_client.h ('k') | chromeos/dbus/gsm_sms_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698