Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Side by Side Diff: chromeos/dbus/shill_profile_client.h

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/dbus/shill_profile_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_SHILL_PROFILE_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_SHILL_PROFILE_CLIENT_H_
6 #define CHROMEOS_DBUS_SHILL_PROFILE_CLIENT_H_ 6 #define CHROMEOS_DBUS_SHILL_PROFILE_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "chromeos/chromeos_export.h" 12 #include "chromeos/chromeos_export.h"
13 #include "chromeos/dbus/dbus_client.h" 13 #include "chromeos/dbus/dbus_client.h"
14 #include "chromeos/dbus/dbus_client_implementation_type.h"
15 #include "chromeos/dbus/shill_client_helper.h" 14 #include "chromeos/dbus/shill_client_helper.h"
16 15
17 namespace base { 16 namespace base {
18 17
19 class Value; 18 class Value;
20 class DictionaryValue; 19 class DictionaryValue;
21 20
22 } // namespace base 21 } // namespace base
23 22
24 namespace dbus { 23 namespace dbus {
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 virtual void GetProfilePaths(std::vector<std::string>* profiles) = 0; 67 virtual void GetProfilePaths(std::vector<std::string>* profiles) = 0;
69 68
70 protected: 69 protected:
71 virtual ~TestInterface() {} 70 virtual ~TestInterface() {}
72 }; 71 };
73 72
74 virtual ~ShillProfileClient(); 73 virtual ~ShillProfileClient();
75 74
76 // Factory function, creates a new instance which is owned by the caller. 75 // Factory function, creates a new instance which is owned by the caller.
77 // For normal usage, access the singleton via DBusThreadManager::Get(). 76 // For normal usage, access the singleton via DBusThreadManager::Get().
78 static ShillProfileClient* Create(DBusClientImplementationType type); 77 static ShillProfileClient* Create();
79 78
80 // Adds a property changed |observer| for the profile at |profile_path|. 79 // Adds a property changed |observer| for the profile at |profile_path|.
81 virtual void AddPropertyChangedObserver( 80 virtual void AddPropertyChangedObserver(
82 const dbus::ObjectPath& profile_path, 81 const dbus::ObjectPath& profile_path,
83 ShillPropertyChangedObserver* observer) = 0; 82 ShillPropertyChangedObserver* observer) = 0;
84 83
85 // Removes a property changed |observer| for the profile at |profile_path|. 84 // Removes a property changed |observer| for the profile at |profile_path|.
86 virtual void RemovePropertyChangedObserver( 85 virtual void RemovePropertyChangedObserver(
87 const dbus::ObjectPath& profile_path, 86 const dbus::ObjectPath& profile_path,
88 ShillPropertyChangedObserver* observer) = 0; 87 ShillPropertyChangedObserver* observer) = 0;
(...skipping 28 matching lines...) Expand all
117 // Create() should be used instead. 116 // Create() should be used instead.
118 ShillProfileClient(); 117 ShillProfileClient();
119 118
120 private: 119 private:
121 DISALLOW_COPY_AND_ASSIGN(ShillProfileClient); 120 DISALLOW_COPY_AND_ASSIGN(ShillProfileClient);
122 }; 121 };
123 122
124 } // namespace chromeos 123 } // namespace chromeos
125 124
126 #endif // CHROMEOS_DBUS_SHILL_PROFILE_CLIENT_H_ 125 #endif // CHROMEOS_DBUS_SHILL_PROFILE_CLIENT_H_
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/dbus/shill_profile_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698