Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: chromeos/dbus/shill_device_client.cc

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/dbus/shill_device_client.h ('k') | chromeos/dbus/shill_device_client_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/shill_device_client.h" 5 #include "chromeos/dbus/shill_device_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chromeos/dbus/fake_shill_device_client.h"
12 #include "chromeos/dbus/shill_property_changed_observer.h" 11 #include "chromeos/dbus/shill_property_changed_observer.h"
13 #include "dbus/bus.h" 12 #include "dbus/bus.h"
14 #include "dbus/message.h" 13 #include "dbus/message.h"
15 #include "dbus/object_path.h" 14 #include "dbus/object_path.h"
16 #include "dbus/object_proxy.h" 15 #include "dbus/object_proxy.h"
17 #include "dbus/values_util.h" 16 #include "dbus/values_util.h"
18 #include "third_party/cros_system_api/dbus/service_constants.h" 17 #include "third_party/cros_system_api/dbus/service_constants.h"
19 18
20 namespace chromeos { 19 namespace chromeos {
21 20
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 DISALLOW_COPY_AND_ASSIGN(ShillDeviceClientImpl); 227 DISALLOW_COPY_AND_ASSIGN(ShillDeviceClientImpl);
229 }; 228 };
230 229
231 } // namespace 230 } // namespace
232 231
233 ShillDeviceClient::ShillDeviceClient() {} 232 ShillDeviceClient::ShillDeviceClient() {}
234 233
235 ShillDeviceClient::~ShillDeviceClient() {} 234 ShillDeviceClient::~ShillDeviceClient() {}
236 235
237 // static 236 // static
238 ShillDeviceClient* ShillDeviceClient::Create( 237 ShillDeviceClient* ShillDeviceClient::Create() {
239 DBusClientImplementationType type) { 238 return new ShillDeviceClientImpl();
240 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
241 return new ShillDeviceClientImpl();
242 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
243 return new FakeShillDeviceClient();
244 } 239 }
245 240
246 } // namespace chromeos 241 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_device_client.h ('k') | chromeos/dbus/shill_device_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698