Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chromeos/dbus/shill_ipconfig_client.h

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/dbus/shill_device_client_unittest.cc ('k') | chromeos/dbus/shill_ipconfig_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_H_
6 #define CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_H_ 6 #define CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "chromeos/chromeos_export.h" 12 #include "chromeos/chromeos_export.h"
13 #include "chromeos/dbus/dbus_client.h" 13 #include "chromeos/dbus/dbus_client.h"
14 #include "chromeos/dbus/dbus_client_implementation_type.h"
15 #include "chromeos/dbus/shill_client_helper.h" 14 #include "chromeos/dbus/shill_client_helper.h"
16 15
17 namespace base { 16 namespace base {
18 17
19 class Value; 18 class Value;
20 class DictionaryValue; 19 class DictionaryValue;
21 20
22 } // namespace base 21 } // namespace base
23 22
24 namespace dbus { 23 namespace dbus {
(...skipping 10 matching lines...) Expand all
35 // service. All methods should be called from the origin thread which 34 // service. All methods should be called from the origin thread which
36 // initializes the DBusThreadManager instance. 35 // initializes the DBusThreadManager instance.
37 class CHROMEOS_EXPORT ShillIPConfigClient : public DBusClient { 36 class CHROMEOS_EXPORT ShillIPConfigClient : public DBusClient {
38 public: 37 public:
39 typedef ShillClientHelper::PropertyChangedHandler PropertyChangedHandler; 38 typedef ShillClientHelper::PropertyChangedHandler PropertyChangedHandler;
40 typedef ShillClientHelper::DictionaryValueCallback DictionaryValueCallback; 39 typedef ShillClientHelper::DictionaryValueCallback DictionaryValueCallback;
41 virtual ~ShillIPConfigClient(); 40 virtual ~ShillIPConfigClient();
42 41
43 // Factory function, creates a new instance which is owned by the caller. 42 // Factory function, creates a new instance which is owned by the caller.
44 // For normal usage, access the singleton via DBusThreadManager::Get(). 43 // For normal usage, access the singleton via DBusThreadManager::Get().
45 static ShillIPConfigClient* Create(DBusClientImplementationType type); 44 static ShillIPConfigClient* Create();
46 45
47 // Adds a property changed |observer| for the ipconfig at |ipconfig_path|. 46 // Adds a property changed |observer| for the ipconfig at |ipconfig_path|.
48 virtual void AddPropertyChangedObserver( 47 virtual void AddPropertyChangedObserver(
49 const dbus::ObjectPath& ipconfig_path, 48 const dbus::ObjectPath& ipconfig_path,
50 ShillPropertyChangedObserver* observer) = 0; 49 ShillPropertyChangedObserver* observer) = 0;
51 50
52 // Removes a property changed |observer| for the ipconfig at |ipconfig_path|. 51 // Removes a property changed |observer| for the ipconfig at |ipconfig_path|.
53 virtual void RemovePropertyChangedObserver( 52 virtual void RemovePropertyChangedObserver(
54 const dbus::ObjectPath& ipconfig_path, 53 const dbus::ObjectPath& ipconfig_path,
55 ShillPropertyChangedObserver* observer) = 0; 54 ShillPropertyChangedObserver* observer) = 0;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 // Create() should be used instead. 87 // Create() should be used instead.
89 ShillIPConfigClient(); 88 ShillIPConfigClient();
90 89
91 private: 90 private:
92 DISALLOW_COPY_AND_ASSIGN(ShillIPConfigClient); 91 DISALLOW_COPY_AND_ASSIGN(ShillIPConfigClient);
93 }; 92 };
94 93
95 } // namespace chromeos 94 } // namespace chromeos
96 95
97 #endif // CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_H_ 96 #endif // CHROMEOS_DBUS_SHILL_IPCONFIG_CLIENT_H_
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_device_client_unittest.cc ('k') | chromeos/dbus/shill_ipconfig_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698