Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chromeos/dbus/shill_service_client.h

Issue 91413002: Remove fake client creation from DBusClients' Create() functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/dbus/shill_profile_client_unittest.cc ('k') | chromeos/dbus/shill_service_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_
6 #define CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_ 6 #define CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "chromeos/chromeos_export.h" 12 #include "chromeos/chromeos_export.h"
13 #include "chromeos/dbus/dbus_client.h" 13 #include "chromeos/dbus/dbus_client.h"
14 #include "chromeos/dbus/dbus_client_implementation_type.h"
15 #include "chromeos/dbus/shill_client_helper.h" 14 #include "chromeos/dbus/shill_client_helper.h"
16 15
17 namespace base { 16 namespace base {
18 17
19 class Value; 18 class Value;
20 class DictionaryValue; 19 class DictionaryValue;
21 20
22 } // namespace base 21 } // namespace base
23 22
24 namespace dbus { 23 namespace dbus {
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 virtual void SetConnectBehavior(const std::string& service_path, 76 virtual void SetConnectBehavior(const std::string& service_path,
78 const base::Closure& behavior) = 0; 77 const base::Closure& behavior) = 0;
79 78
80 protected: 79 protected:
81 virtual ~TestInterface() {} 80 virtual ~TestInterface() {}
82 }; 81 };
83 virtual ~ShillServiceClient(); 82 virtual ~ShillServiceClient();
84 83
85 // Factory function, creates a new instance which is owned by the caller. 84 // Factory function, creates a new instance which is owned by the caller.
86 // For normal usage, access the singleton via DBusThreadManager::Get(). 85 // For normal usage, access the singleton via DBusThreadManager::Get().
87 static ShillServiceClient* Create(DBusClientImplementationType type); 86 static ShillServiceClient* Create();
88 87
89 // Adds a property changed |observer| to the service at |service_path|. 88 // Adds a property changed |observer| to the service at |service_path|.
90 virtual void AddPropertyChangedObserver( 89 virtual void AddPropertyChangedObserver(
91 const dbus::ObjectPath& service_path, 90 const dbus::ObjectPath& service_path,
92 ShillPropertyChangedObserver* observer) = 0; 91 ShillPropertyChangedObserver* observer) = 0;
93 92
94 // Removes a property changed |observer| to the service at |service_path|. 93 // Removes a property changed |observer| to the service at |service_path|.
95 virtual void RemovePropertyChangedObserver( 94 virtual void RemovePropertyChangedObserver(
96 const dbus::ObjectPath& service_path, 95 const dbus::ObjectPath& service_path,
97 ShillPropertyChangedObserver* observer) = 0; 96 ShillPropertyChangedObserver* observer) = 0;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 // Create() should be used instead. 177 // Create() should be used instead.
179 ShillServiceClient(); 178 ShillServiceClient();
180 179
181 private: 180 private:
182 DISALLOW_COPY_AND_ASSIGN(ShillServiceClient); 181 DISALLOW_COPY_AND_ASSIGN(ShillServiceClient);
183 }; 182 };
184 183
185 } // namespace chromeos 184 } // namespace chromeos
186 185
187 #endif // CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_ 186 #endif // CHROMEOS_DBUS_SHILL_SERVICE_CLIENT_H_
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_profile_client_unittest.cc ('k') | chromeos/dbus/shill_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698