Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 90333003: Remove --enable-gpu-service-logging and --enable-gpu-client-logging (Closed)

Created:
7 years ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, piman+watch_chromium.org
Visibility:
Public.

Description

Remove --enable-gpu-service-logging and --enable-gpu-client-logging This removes hundreds of lines of code, thousands of lines of generated code (the generated gl bindings files are only about half as large after this change), and reduced binary size by 20kB. The command buffer code doesn't change much any more. People who need logging for debugging can add some locally. BUG=322805

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1134 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 19 chunks +1 line, -69 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 4 2 chunks +4 lines, -16 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 4 88 chunks +3 lines, -395 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 2 3 4 107 chunks +0 lines, -344 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 14 chunks +2 lines, -59 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M ui/gl/generate_bindings.py View 7 chunks +6 lines, -123 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 2 3 5 chunks +0 lines, -5 lines 0 comments Download
M ui/gl/gl_egl_api_implementation.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_egl_api_implementation.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_glx_api_implementation.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_glx_api_implementation.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_implementation.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_implementation_android.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_implementation_mac.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gl/gl_implementation_ozone.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gl/gl_implementation_x11.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gl/gl_osmesa_api_implementation.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_osmesa_api_implementation.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gl/gl_switches.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ui/gl/gl_wgl_api_implementation.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_wgl_api_implementation.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years ago (2013-11-27 18:00:58 UTC) #1
piman
7 years ago (2013-12-03 01:01:47 UTC) #2
I do appreciate the reduced binary size... However this code has been used in
the past to debug issues - the point being that it logs *everything*, which you
kinda need to do to debug GL state (since it's not directly accessible). It's
not so much about logging/debugging the command buffer stuff, but helping to
debug gl clients.
How about making it debug-only, so that we still get the binary reduction?

Powered by Google App Engine
This is Rietveld 408576698