Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_reject
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Update .focus() to return a WindowClient instead of bool. This is simply adding the new interface so that Chromium can use it. Spec is here: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#client It is a three sided CL: Part 1: <this> Part 2: https://codereview.chromium.org/894853007 Part 3: https://codereview.chromium.org/868233006 BUG=447212 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189431

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.h View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp View 2 chunks +11 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 chunk +6 lines, -8 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-02 17:55:01 UTC) #2
dominicc (has gone to gerrit)
On 2015/02/02 at 17:55:01, mlamouri wrote: > LGTM
5 years, 10 months ago (2015-02-02 17:59:23 UTC) #3
mlamouri (slow - plz ping)
Mike, can you do an OWNERS review of this?
5 years, 10 months ago (2015-02-02 18:01:36 UTC) #5
Mike West
LGTM, assuming you want to ASSERT not reached. https://codereview.chromium.org/897493002/diff/1/public/web/WebServiceWorkerContextClient.h File public/web/WebServiceWorkerContextClient.h (right): https://codereview.chromium.org/897493002/diff/1/public/web/WebServiceWorkerContextClient.h#newcode176 public/web/WebServiceWorkerContextClient.h:176: virtual ...
5 years, 10 months ago (2015-02-02 18:11:18 UTC) #6
mlamouri (slow - plz ping)
https://codereview.chromium.org/897493002/diff/1/public/web/WebServiceWorkerContextClient.h File public/web/WebServiceWorkerContextClient.h (right): https://codereview.chromium.org/897493002/diff/1/public/web/WebServiceWorkerContextClient.h#newcode176 public/web/WebServiceWorkerContextClient.h:176: virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) { BLINK_ASSERT_NOT_REACHED(); } On ...
5 years, 10 months ago (2015-02-03 16:55:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897493002/1
5 years, 10 months ago (2015-02-03 16:57:08 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 18:44:20 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189431

Powered by Google App Engine
This is Rietveld 408576698