Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_reject

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | public/web/WebServiceWorkerContextClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index dc10ae30676ad63dd26b2d6ac42e25fab131ee78..384e57ad042fd34fc39677d21baad0864b765cce 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -65,6 +65,7 @@ public:

virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) override;

virtual void claim(WebServiceWorkerClientsClaimCallbacks*) override;

virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) override;

+ virtual void focus(int clientID, WebServiceWorkerClientCallbacks*) override;

virtual void trace(Visitor* visitor) override { ServiceWorkerGlobalScopeClient::trace(visitor); }