Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_reject

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 3c51e4c4ab7dd69500af1ef2d8e1eed0e611b467..f09504f01dee52c5e53b1680e1b7b89b70e5cd47 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -76,6 +76,7 @@ public:

virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) = 0;

virtual void claim(WebServiceWorkerClientsClaimCallbacks*) = 0;

virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) = 0;

+ virtual void focus(int clientID, WebServiceWorkerClientCallbacks*) = 0;

static const char* supplementName();

static ServiceWorkerGlobalScopeClient* from(ExecutionContext*);

« no previous file with comments | « no previous file | Source/modules/serviceworkers/ServiceWorkerWindowClient.h » ('j') | public/web/WebServiceWorkerContextClient.h » ('J')