Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Side by Side Diff: public/web/WebServiceWorkerContextClient.h

Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_reject
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 // Ownership of the passed callbacks is transferred to the callee, callee 165 // Ownership of the passed callbacks is transferred to the callee, callee
166 // should delete the callbacks after run. 166 // should delete the callbacks after run.
167 virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) { BLINK_ASSE RT_NOT_REACHED(); } 167 virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) { BLINK_ASSE RT_NOT_REACHED(); }
168 168
169 // Ownership of the passed callbacks is transferred to the callee, callee 169 // Ownership of the passed callbacks is transferred to the callee, callee
170 // should delete the callbacks after run. 170 // should delete the callbacks after run.
171 virtual void claim(WebServiceWorkerClientsClaimCallbacks*) { BLINK_ASSERT_NO T_REACHED(); } 171 virtual void claim(WebServiceWorkerClientsClaimCallbacks*) { BLINK_ASSERT_NO T_REACHED(); }
172 172
173 // Ownership of the passed callbacks is transferred to the callee, callee 173 // Ownership of the passed callbacks is transferred to the callee, callee
174 // should delete the callback after calling either onSuccess or onError. 174 // should delete the callback after calling either onSuccess or onError.
175 virtual void focus(int clientID, WebServiceWorkerClientFocusCallback* callba ck) 175 // FIXME: delete this method as soon as Chromium stop calling it.
176 { 176 virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) { BLI NK_ASSERT_NOT_REACHED(); }
Mike West 2015/02/02 18:11:18 Is the assert what you want?
mlamouri (slow - plz ping) 2015/02/03 16:55:56 Yes :)
177 // FIXME: call BLINK_ASSERT_NOT_REACHED() when Chromium implementation 177
178 // is present. https://crbug.com/437149 178 // Ownership of the passed callbacks is transferred to the callee, callee
179 bool result = true; 179 // should delete the callback after calling either onSuccess or onError.
180 callback->onSuccess(&result); 180 virtual void focus(int cliendID, WebServiceWorkerClientCallbacks*) { BLINK_A SSERT_NOT_REACHED(); }
181 delete callback;
182 }
183 }; 181 };
184 182
185 } // namespace blink 183 } // namespace blink
186 184
187 #endif // WebServiceWorkerContextClient_h 185 #endif // WebServiceWorkerContextClient_h
OLDNEW
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698