Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_reject
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebServiceWorkerContextClient.h
diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h
index 3118298353c941e36cefc1a0c056dbef52a4bd25..46ee8928f26b53b7249160c2eebf67aee45b165c 100644
--- a/public/web/WebServiceWorkerContextClient.h
+++ b/public/web/WebServiceWorkerContextClient.h
@@ -172,14 +172,12 @@ public:
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callback after calling either onSuccess or onError.
- virtual void focus(int clientID, WebServiceWorkerClientFocusCallback* callback)
- {
- // FIXME: call BLINK_ASSERT_NOT_REACHED() when Chromium implementation
- // is present. https://crbug.com/437149
- bool result = true;
- callback->onSuccess(&result);
- delete callback;
- }
+ // FIXME: delete this method as soon as Chromium stop calling it.
+ virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) { BLINK_ASSERT_NOT_REACHED(); }
Mike West 2015/02/02 18:11:18 Is the assert what you want?
mlamouri (slow - plz ping) 2015/02/03 16:55:56 Yes :)
+
+ // Ownership of the passed callbacks is transferred to the callee, callee
+ // should delete the callback after calling either onSuccess or onError.
+ virtual void focus(int cliendID, WebServiceWorkerClientCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
};
} // namespace blink
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698