Chromium Code Reviews| Index: public/web/WebServiceWorkerContextClient.h |
| diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h |
| index 3118298353c941e36cefc1a0c056dbef52a4bd25..46ee8928f26b53b7249160c2eebf67aee45b165c 100644 |
| --- a/public/web/WebServiceWorkerContextClient.h |
| +++ b/public/web/WebServiceWorkerContextClient.h |
| @@ -172,14 +172,12 @@ public: |
| // Ownership of the passed callbacks is transferred to the callee, callee |
| // should delete the callback after calling either onSuccess or onError. |
| - virtual void focus(int clientID, WebServiceWorkerClientFocusCallback* callback) |
| - { |
| - // FIXME: call BLINK_ASSERT_NOT_REACHED() when Chromium implementation |
| - // is present. https://crbug.com/437149 |
| - bool result = true; |
| - callback->onSuccess(&result); |
| - delete callback; |
| - } |
| + // FIXME: delete this method as soon as Chromium stop calling it. |
| + virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) { BLINK_ASSERT_NOT_REACHED(); } |
|
Mike West
2015/02/02 18:11:18
Is the assert what you want?
mlamouri (slow - plz ping)
2015/02/03 16:55:56
Yes :)
|
| + |
| + // Ownership of the passed callbacks is transferred to the callee, callee |
| + // should delete the callback after calling either onSuccess or onError. |
| + virtual void focus(int cliendID, WebServiceWorkerClientCallbacks*) { BLINK_ASSERT_NOT_REACHED(); } |
| }; |
| } // namespace blink |