Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 894853007: [ServiceWorker] Update SWProviderHost::Focus() to return a Client. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, michaeln
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@sw_open_window
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Update SWProviderHost::Focus() to return a Client. Instead of returning a boolean to say whether the focus suceeded, this is now returning an updated WindowClient which will contain the new focus state. This is a three sided CL: Part 1: https://codereview.chromium.org/897493002 Part 2: <this> Part 3: https://codereview.chromium.org/868233006 BUG=447212 Committed: https://crrev.com/aa91264da88443db4f6ec11c286b7abe8493ded9 Cr-Commit-Position: refs/heads/master@{#315018}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rebase #

Patch Set 4 : #

Messages

Total messages: 9 (3 generated)
mlamouri (slow - plz ping)
tsepez@, please review: content/common/service_worker/service_worker_messages.h michaeln@, please review: content/browser/service_worker/service_worker_provider_host.cc content/browser/service_worker/service_worker_provider_host.h content/browser/service_worker/service_worker_version.cc content/browser/service_worker/service_worker_version.h content/renderer/service_worker/embedded_worker_context_client.cc content/renderer/service_worker/embedded_worker_context_client.h content/renderer/service_worker/service_worker_script_context.cc content/renderer/service_worker/service_worker_script_context.h ...
5 years, 10 months ago (2015-02-03 16:52:36 UTC) #2
Tom Sepez
Messages LGTM.
5 years, 10 months ago (2015-02-03 20:36:58 UTC) #3
michaeln
lgtm 2
5 years, 10 months ago (2015-02-04 01:03:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894853007/60001
5 years, 10 months ago (2015-02-06 12:03:26 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-06 13:10:42 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 13:11:49 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/aa91264da88443db4f6ec11c286b7abe8493ded9
Cr-Commit-Position: refs/heads/master@{#315018}

Powered by Google App Engine
This is Rietveld 408576698