Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 868233006: [ServiceWorker] Cleanup to remove old focus() code kept to not break Chromium. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_client
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Cleanup to remove old focus() code kept to not break Chromium. It is a three sided CL: Part 1: https://codereview.chromium.org/897493002 Part 2: https://codereview.chromium.org/894853007 Part 3: <this> BUG=447212 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189745

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D public/platform/WebServiceWorkerClientFocusCallback.h View 1 chunk +0 lines, -18 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 2 chunks +0 lines, -6 lines 2 comments Download

Messages

Total messages: 18 (7 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-02 18:00:24 UTC) #2
mlamouri (slow - plz ping)
+mkwst@ for non modules/ changes.
5 years, 10 months ago (2015-02-02 18:02:11 UTC) #4
Mike West
LGTM.
5 years, 10 months ago (2015-02-02 18:11:48 UTC) #5
dominicc (has gone to gerrit)
LGTM too; one comment inline at your discretion. https://codereview.chromium.org/868233006/diff/1/public/web/WebServiceWorkerContextClient.h File public/web/WebServiceWorkerContextClient.h (left): https://codereview.chromium.org/868233006/diff/1/public/web/WebServiceWorkerContextClient.h#oldcode178 public/web/WebServiceWorkerContextClient.h:178: // ...
5 years, 10 months ago (2015-02-02 18:25:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233006/1
5 years, 10 months ago (2015-02-06 14:05:36 UTC) #8
mlamouri (slow - plz ping)
https://codereview.chromium.org/868233006/diff/1/public/web/WebServiceWorkerContextClient.h File public/web/WebServiceWorkerContextClient.h (left): https://codereview.chromium.org/868233006/diff/1/public/web/WebServiceWorkerContextClient.h#oldcode178 public/web/WebServiceWorkerContextClient.h:178: // Ownership of the passed callbacks is transferred to ...
5 years, 10 months ago (2015-02-06 14:05:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41746)
5 years, 10 months ago (2015-02-06 18:55:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233006/1
5 years, 10 months ago (2015-02-07 13:51:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41891)
5 years, 10 months ago (2015-02-07 15:13:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868233006/1
5 years, 10 months ago (2015-02-07 15:16:30 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 16:25:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189745

Powered by Google App Engine
This is Rietveld 408576698