Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 897493002: [ServiceWorker] Update .focus() to return a WindowClient instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_reject

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | public/web/WebServiceWorkerContextClient.h » ('j') | public/web/WebServiceWorkerContextClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 7dd323571d3e6831199a5436e951afb61aec6511..c834c21ac249d425d3218206cbf4fd1d306a30c0 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -128,6 +128,11 @@ void ServiceWorkerGlobalScopeClientImpl::focus(int clientID, WebServiceWorkerCli

m_client.focus(clientID, callback);

}

+void ServiceWorkerGlobalScopeClientImpl::focus(int clientID, WebServiceWorkerClientCallbacks* callback)

+ m_client.focus(clientID, callback);

ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(WebServiceWorkerContextClient& client)

: m_client(client)

{