Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed)

Created:
5 years, 10 months ago by mvstanton
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Super Constructor Calls need to use a vector slot, not an ic slot. The Ast Call node is accustomed to using a vector IC slot for the cases when it uses a CallIC. The super constructor work alters this somewhat by using a CallConstructStub instead, however the CallConstructStub expects a vector slot and not a vector ic slot. This distinction needs to be maintained because slots and ic slots have different clearing strategies and are handled differently. R=dslomov@chromium.org BUG= LOG=N Committed: https://crrev.com/64f81870ee0bc51a32620be8face35e7cbd0da92 Cr-Commit-Position: refs/heads/master@{#26414}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 1 2 4 chunks +17 lines, -7 lines 0 comments Download
M src/ast.cc View 1 chunk +17 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/type-feedback-vector.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/typing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
mvstanton
Hi Dmitry, Can you have a look at this? It is a fix for an ...
5 years, 10 months ago (2015-02-02 09:13:54 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-03 13:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892113002/40001
5 years, 10 months ago (2015-02-03 18:52:16 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 19:16:24 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:17:01 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64f81870ee0bc51a32620be8face35e7cbd0da92
Cr-Commit-Position: refs/heads/master@{#26414}

Powered by Google App Engine
This is Rietveld 408576698