src/ia32/full-codegen-ia32.cc - Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 178c394c19cdbefa44e83b49a482e051e5528a3b..f0ee7f4b2c1d63ca888193ca7f33f13c0e325ea6 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2904,7 +2904,7 @@ void FullCodeGenerator::EmitCall(Call* expr, CallICState::CallType call_type) {

// Record source position of the IC call.

SetSourcePosition(expr->position());

Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code();

- __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackSlot())));

+ __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackICSlot())));

__ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize));

// Don't assign a type feedback id to the IC, since type feedback is provided

// by the vector above.

« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »