Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: src/typing.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/type-feedback-vector.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/typing.h" 5 #include "src/typing.h"
6 6
7 #include "src/frames.h" 7 #include "src/frames.h"
8 #include "src/frames-inl.h" 8 #include "src/frames-inl.h"
9 #include "src/ostreams.h" 9 #include "src/ostreams.h"
10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move 10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 RECURSE(Visit(expr->key())); 525 RECURSE(Visit(expr->key()));
526 526
527 // We don't know anything about the result type. 527 // We don't know anything about the result type.
528 } 528 }
529 529
530 530
531 void AstTyper::VisitCall(Call* expr) { 531 void AstTyper::VisitCall(Call* expr) {
532 // Collect type feedback. 532 // Collect type feedback.
533 RECURSE(Visit(expr->expression())); 533 RECURSE(Visit(expr->expression()));
534 bool is_uninitialized = true; 534 bool is_uninitialized = true;
535 if (expr->IsUsingCallFeedbackSlot(isolate())) { 535 if (expr->IsUsingCallFeedbackICSlot(isolate())) {
536 FeedbackVectorICSlot slot = expr->CallFeedbackSlot(); 536 FeedbackVectorICSlot slot = expr->CallFeedbackICSlot();
537 is_uninitialized = oracle()->CallIsUninitialized(slot); 537 is_uninitialized = oracle()->CallIsUninitialized(slot);
538 if (!expr->expression()->IsProperty() && 538 if (!expr->expression()->IsProperty() &&
539 oracle()->CallIsMonomorphic(slot)) { 539 oracle()->CallIsMonomorphic(slot)) {
540 expr->set_target(oracle()->GetCallTarget(slot)); 540 expr->set_target(oracle()->GetCallTarget(slot));
541 Handle<AllocationSite> site = oracle()->GetCallAllocationSite(slot); 541 Handle<AllocationSite> site = oracle()->GetCallAllocationSite(slot);
542 expr->set_allocation_site(site); 542 expr->set_allocation_site(site);
543 } 543 }
544 } 544 }
545 545
546 expr->set_is_uninitialized(is_uninitialized); 546 expr->set_is_uninitialized(is_uninitialized);
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 809 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
810 } 810 }
811 811
812 812
813 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 813 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
814 RECURSE(Visit(stmt->body())); 814 RECURSE(Visit(stmt->body()));
815 } 815 }
816 816
817 817
818 } } // namespace v8::internal 818 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-feedback-vector.h ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698