Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2989 matching lines...) Expand 10 before | Expand all | Expand 10 after
3000 int arg_count = args->length(); 3000 int arg_count = args->length();
3001 { PreservePositionScope scope(masm()->positions_recorder()); 3001 { PreservePositionScope scope(masm()->positions_recorder());
3002 for (int i = 0; i < arg_count; i++) { 3002 for (int i = 0; i < arg_count; i++) {
3003 VisitForStackValue(args->at(i)); 3003 VisitForStackValue(args->at(i));
3004 } 3004 }
3005 } 3005 }
3006 3006
3007 // Record source position of the IC call. 3007 // Record source position of the IC call.
3008 SetSourcePosition(expr->position()); 3008 SetSourcePosition(expr->position());
3009 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code(); 3009 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code();
3010 __ mov(r3, Operand(SmiFromSlot(expr->CallFeedbackSlot()))); 3010 __ mov(r3, Operand(SmiFromSlot(expr->CallFeedbackICSlot())));
3011 __ ldr(r1, MemOperand(sp, (arg_count + 1) * kPointerSize)); 3011 __ ldr(r1, MemOperand(sp, (arg_count + 1) * kPointerSize));
3012 // Don't assign a type feedback id to the IC, since type feedback is provided 3012 // Don't assign a type feedback id to the IC, since type feedback is provided
3013 // by the vector above. 3013 // by the vector above.
3014 CallIC(ic); 3014 CallIC(ic);
3015 3015
3016 RecordJSReturnSite(expr); 3016 RecordJSReturnSite(expr);
3017 // Restore context register. 3017 // Restore context register.
3018 __ ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); 3018 __ ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
3019 context()->DropAndPlug(1, r0); 3019 context()->DropAndPlug(1, r0);
3020 } 3020 }
(...skipping 2398 matching lines...) Expand 10 before | Expand all | Expand 10 after
5419 5419
5420 DCHECK(interrupt_address == 5420 DCHECK(interrupt_address ==
5421 isolate->builtins()->OsrAfterStackCheck()->entry()); 5421 isolate->builtins()->OsrAfterStackCheck()->entry());
5422 return OSR_AFTER_STACK_CHECK; 5422 return OSR_AFTER_STACK_CHECK;
5423 } 5423 }
5424 5424
5425 5425
5426 } } // namespace v8::internal 5426 } } // namespace v8::internal
5427 5427
5428 #endif // V8_TARGET_ARCH_ARM 5428 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698