Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2677 matching lines...) Expand 10 before | Expand all | Expand 10 after
2688 int arg_count = args->length(); 2688 int arg_count = args->length();
2689 { PreservePositionScope scope(masm()->positions_recorder()); 2689 { PreservePositionScope scope(masm()->positions_recorder());
2690 for (int i = 0; i < arg_count; i++) { 2690 for (int i = 0; i < arg_count; i++) {
2691 VisitForStackValue(args->at(i)); 2691 VisitForStackValue(args->at(i));
2692 } 2692 }
2693 } 2693 }
2694 // Record source position of the IC call. 2694 // Record source position of the IC call.
2695 SetSourcePosition(expr->position()); 2695 SetSourcePosition(expr->position());
2696 2696
2697 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code(); 2697 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code();
2698 __ Mov(x3, SmiFromSlot(expr->CallFeedbackSlot())); 2698 __ Mov(x3, SmiFromSlot(expr->CallFeedbackICSlot()));
2699 __ Peek(x1, (arg_count + 1) * kXRegSize); 2699 __ Peek(x1, (arg_count + 1) * kXRegSize);
2700 // Don't assign a type feedback id to the IC, since type feedback is provided 2700 // Don't assign a type feedback id to the IC, since type feedback is provided
2701 // by the vector above. 2701 // by the vector above.
2702 CallIC(ic); 2702 CallIC(ic);
2703 2703
2704 RecordJSReturnSite(expr); 2704 RecordJSReturnSite(expr);
2705 // Restore context register. 2705 // Restore context register.
2706 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); 2706 __ Ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
2707 context()->DropAndPlug(1, x0); 2707 context()->DropAndPlug(1, x0);
2708 } 2708 }
(...skipping 2689 matching lines...) Expand 10 before | Expand all | Expand 10 after
5398 return previous_; 5398 return previous_;
5399 } 5399 }
5400 5400
5401 5401
5402 #undef __ 5402 #undef __
5403 5403
5404 5404
5405 } } // namespace v8::internal 5405 } } // namespace v8::internal
5406 5406
5407 #endif // V8_TARGET_ARCH_ARM64 5407 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698