src/arm64/full-codegen-arm64.cc - Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/full-codegen-arm64.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/full-codegen-arm64.cc

diff --git a/src/arm64/full-codegen-arm64.cc b/src/arm64/full-codegen-arm64.cc

index 62b5451668ac0292cc5c0355d34d610624d7340e..3841838595a44e6f3f159f71a3503d57b82a7502 100644

--- a/src/arm64/full-codegen-arm64.cc

+++ b/src/arm64/full-codegen-arm64.cc

@@ -2695,7 +2695,7 @@ void FullCodeGenerator::EmitCall(Call* expr, CallICState::CallType call_type) {

SetSourcePosition(expr->position());

Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code();

- __ Mov(x3, SmiFromSlot(expr->CallFeedbackSlot()));

+ __ Mov(x3, SmiFromSlot(expr->CallFeedbackICSlot()));

__ Peek(x1, (arg_count + 1) * kXRegSize);

// Don't assign a type feedback id to the IC, since type feedback is provided

// by the vector above.

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »