Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 2960 matching lines...) Expand 10 before | Expand all | Expand 10 after
2971 int arg_count = args->length(); 2971 int arg_count = args->length();
2972 { PreservePositionScope scope(masm()->positions_recorder()); 2972 { PreservePositionScope scope(masm()->positions_recorder());
2973 for (int i = 0; i < arg_count; i++) { 2973 for (int i = 0; i < arg_count; i++) {
2974 VisitForStackValue(args->at(i)); 2974 VisitForStackValue(args->at(i));
2975 } 2975 }
2976 } 2976 }
2977 2977
2978 // Record source position of the IC call. 2978 // Record source position of the IC call.
2979 SetSourcePosition(expr->position()); 2979 SetSourcePosition(expr->position());
2980 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code(); 2980 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code();
2981 __ li(a3, Operand(SmiFromSlot(expr->CallFeedbackSlot()))); 2981 __ li(a3, Operand(SmiFromSlot(expr->CallFeedbackICSlot())));
2982 __ lw(a1, MemOperand(sp, (arg_count + 1) * kPointerSize)); 2982 __ lw(a1, MemOperand(sp, (arg_count + 1) * kPointerSize));
2983 // Don't assign a type feedback id to the IC, since type feedback is provided 2983 // Don't assign a type feedback id to the IC, since type feedback is provided
2984 // by the vector above. 2984 // by the vector above.
2985 CallIC(ic); 2985 CallIC(ic);
2986 2986
2987 RecordJSReturnSite(expr); 2987 RecordJSReturnSite(expr);
2988 // Restore context register. 2988 // Restore context register.
2989 __ lw(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); 2989 __ lw(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
2990 context()->DropAndPlug(1, v0); 2990 context()->DropAndPlug(1, v0);
2991 } 2991 }
(...skipping 2351 matching lines...) Expand 10 before | Expand all | Expand 10 after
5343 Assembler::target_address_at(pc_immediate_load_address)) == 5343 Assembler::target_address_at(pc_immediate_load_address)) ==
5344 reinterpret_cast<uint32_t>( 5344 reinterpret_cast<uint32_t>(
5345 isolate->builtins()->OsrAfterStackCheck()->entry())); 5345 isolate->builtins()->OsrAfterStackCheck()->entry()));
5346 return OSR_AFTER_STACK_CHECK; 5346 return OSR_AFTER_STACK_CHECK;
5347 } 5347 }
5348 5348
5349 5349
5350 } } // namespace v8::internal 5350 } } // namespace v8::internal
5351 5351
5352 #endif // V8_TARGET_ARCH_MIPS 5352 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698