Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 892113002: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2886 matching lines...) Expand 10 before | Expand all | Expand 10 after
2897 int arg_count = args->length(); 2897 int arg_count = args->length();
2898 { PreservePositionScope scope(masm()->positions_recorder()); 2898 { PreservePositionScope scope(masm()->positions_recorder());
2899 for (int i = 0; i < arg_count; i++) { 2899 for (int i = 0; i < arg_count; i++) {
2900 VisitForStackValue(args->at(i)); 2900 VisitForStackValue(args->at(i));
2901 } 2901 }
2902 } 2902 }
2903 2903
2904 // Record source position of the IC call. 2904 // Record source position of the IC call.
2905 SetSourcePosition(expr->position()); 2905 SetSourcePosition(expr->position());
2906 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code(); 2906 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code();
2907 __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackSlot()))); 2907 __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackICSlot())));
2908 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize)); 2908 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize));
2909 // Don't assign a type feedback id to the IC, since type feedback is provided 2909 // Don't assign a type feedback id to the IC, since type feedback is provided
2910 // by the vector above. 2910 // by the vector above.
2911 CallIC(ic); 2911 CallIC(ic);
2912 2912
2913 RecordJSReturnSite(expr); 2913 RecordJSReturnSite(expr);
2914 2914
2915 // Restore context register. 2915 // Restore context register.
2916 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset)); 2916 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
2917 2917
(...skipping 2370 matching lines...) Expand 10 before | Expand all | Expand 10 after
5288 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5288 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5289 Assembler::target_address_at(call_target_address, 5289 Assembler::target_address_at(call_target_address,
5290 unoptimized_code)); 5290 unoptimized_code));
5291 return OSR_AFTER_STACK_CHECK; 5291 return OSR_AFTER_STACK_CHECK;
5292 } 5292 }
5293 5293
5294 5294
5295 } } // namespace v8::internal 5295 } } // namespace v8::internal
5296 5296
5297 #endif // V8_TARGET_ARCH_IA32 5297 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698