Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecated v8::base::OS::nan_value(). Use std::numeric_limits<double>::quiet_NaN() and std::numeric_limits<float>::quiet_NaN() instead. Committed: https://crrev.com/4b31a97da399084dc90e371fffdb4d301caae390 Cr-Commit-Position: refs/heads/master@{#26195}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix invalid test expectation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -172 lines) Patch
M src/api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/base/platform/platform-posix.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M src/json-parser.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/types.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-checks.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-conversions.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M test/cctest/test-double.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 5 chunks +60 lines, -91 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-21 13:50:49 UTC) #2
Jakob Kummerow
I don't really see the value this CL adds, but if it makes you happy... ...
5 years, 11 months ago (2015-01-21 14:02:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864803002/20001
5 years, 11 months ago (2015-01-21 14:04:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 14:38:57 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:39:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b31a97da399084dc90e371fffdb4d301caae390
Cr-Commit-Position: refs/heads/master@{#26195}

Powered by Google App Engine
This is Rietveld 408576698