test/cctest/test-utils.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-utils.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-utils.cc

diff --git a/test/cctest/test-utils.cc b/test/cctest/test-utils.cc

index 05a12f5c2378ec4466cf76ca7a6fb1a200f774f8..46adc0b23d8d5e51d30cb50981e95acab93dbc20 100644

--- a/test/cctest/test-utils.cc

+++ b/test/cctest/test-utils.cc

@@ -72,7 +72,7 @@ TEST(Utils1) {

CHECK_EQ(INT_MAX, FastD2IChecked(1.0e100));

CHECK_EQ(INT_MIN, FastD2IChecked(-1.0e100));

- CHECK_EQ(INT_MIN, FastD2IChecked(v8::base::OS::nan_value()));

+ CHECK_EQ(INT_MIN, FastD2IChecked(std::numeric_limits<double>::quiet_NaN()));

}

« no previous file with comments | « test/cctest/test-types.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »