test/cctest/compiler/test-js-constant-cache.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-js-constant-cache.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-js-constant-cache.cc

diff --git a/test/cctest/compiler/test-js-constant-cache.cc b/test/cctest/compiler/test-js-constant-cache.cc

index 8588f66f1f546f7a6161e0f5d9f04b6752bc19ab..5a389c2df1b098b40754ccf31551832100af3b09 100644

--- a/test/cctest/compiler/test-js-constant-cache.cc

+++ b/test/cctest/compiler/test-js-constant-cache.cc

@@ -65,7 +65,7 @@ TEST(ZeroConstant1) {

CHECK_EQ(zero, T.Constant(0));

CHECK_NE(zero, T.Constant(-0.0));

CHECK_NE(zero, T.Constant(1.0));

- CHECK_NE(zero, T.Constant(v8::base::OS::nan_value()));

+ CHECK_NE(zero, T.Constant(std::numeric_limits<double>::quiet_NaN()));

CHECK_NE(zero, T.Float64Constant(0));

CHECK_NE(zero, T.Int32Constant(0));

@@ -119,7 +119,7 @@ TEST(ZeroConstant2) {

CHECK_EQ(zero, T.ZeroConstant());

CHECK_NE(zero, T.Constant(-0.0));

CHECK_NE(zero, T.Constant(1.0));

- CHECK_NE(zero, T.Constant(v8::base::OS::nan_value()));

+ CHECK_NE(zero, T.Constant(std::numeric_limits<double>::quiet_NaN()));

CHECK_NE(zero, T.Float64Constant(0));

CHECK_NE(zero, T.Int32Constant(0));

@@ -144,7 +144,7 @@ TEST(OneConstant1) {

CHECK_EQ(one, T.Constant(1.0));

CHECK_NE(one, T.Constant(1.01));

CHECK_NE(one, T.Constant(-1.01));

- CHECK_NE(one, T.Constant(v8::base::OS::nan_value()));

+ CHECK_NE(one, T.Constant(std::numeric_limits<double>::quiet_NaN()));

CHECK_NE(one, T.Float64Constant(1.0));

CHECK_NE(one, T.Int32Constant(1));