test/cctest/compiler/codegen-tester.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/codegen-tester.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/codegen-tester.cc

diff --git a/test/cctest/compiler/codegen-tester.cc b/test/cctest/compiler/codegen-tester.cc

index 5311001714c87aeabb8d68e08352ade30a921105..b20da872eb23460abf6838af693c889614db7ff5 100644

--- a/test/cctest/compiler/codegen-tester.cc

+++ b/test/cctest/compiler/codegen-tester.cc

@@ -141,7 +141,7 @@ TEST(CompareWrapper) {

CompareWrapper wFloat64LessThanOrEqual(IrOpcode::kFloat64LessThanOrEqual);

// Check NaN handling.

- double nan = v8::base::OS::nan_value();

+ double nan = std::numeric_limits<double>::quiet_NaN();

double inf = V8_INFINITY;

CHECK_EQ(false, wFloat64Equal.Float64Compare(nan, 0.0));

CHECK_EQ(false, wFloat64Equal.Float64Compare(nan, 1.0));

« no previous file with comments | « src/types.cc ('k') | test/cctest/compiler/test-branch-combine.cc » ('j') | no next file with comments »