test/unittests/compiler/js-typed-lowering-unittest.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/js-typed-lowering-unittest.cc

diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc

index 42ba64b9bcbc2cc2e3f35d27a8e9cebd6560ba8f..9886c267b82fc387eba046f122395f83255acfb7 100644

--- a/test/unittests/compiler/js-typed-lowering-unittest.cc

+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc

@@ -228,7 +228,7 @@ TEST_F(JSTypedLoweringTest, ParameterWithNull) {

TEST_F(JSTypedLoweringTest, ParameterWithNaN) {

- const double kNaNs[] = {base::OS::nan_value(),

+ const double kNaNs[] = {-std::numeric_limits<double>::quiet_NaN(),

std::numeric_limits<double>::quiet_NaN(),

std::numeric_limits<double>::signaling_NaN()};

TRACED_FOREACH(double, nan, kNaNs) {