src/runtime/runtime-numbers.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-numbers.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-numbers.cc

diff --git a/src/runtime/runtime-numbers.cc b/src/runtime/runtime-numbers.cc

index bc0bb3656dccc9c61cd5cc8cfe81e262d3fc7d58..a7a15e476b070e30db938d77febb5e6dbdb171a8 100644

--- a/src/runtime/runtime-numbers.cc

+++ b/src/runtime/runtime-numbers.cc

@@ -229,8 +229,9 @@ RUNTIME_FUNCTION(Runtime_StringParseFloat) {

DCHECK(args.length() == 1);

CONVERT_ARG_HANDLE_CHECKED(String, subject, 0);

- double value = StringToDouble(isolate->unicode_cache(), subject,

- ALLOW_TRAILING_JUNK, base::OS::nan_value());

+ double value =

+ StringToDouble(isolate->unicode_cache(), subject, ALLOW_TRAILING_JUNK,

+ std::numeric_limits<double>::quiet_NaN());

return *isolate->factory()->NewNumber(value);

}

« no previous file with comments | « src/objects-inl.h ('k') | src/third_party/fdlibm/fdlibm.cc » ('j') | no next file with comments »