test/cctest/compiler/test-branch-combine.cc - Issue 864803002: Remove deprecated v8::base::OS::nan_value().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-branch-combine.cc

Issue 864803002: Remove deprecated v8::base::OS::nan_value(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix invalid test expectation. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-branch-combine.cc

diff --git a/test/cctest/compiler/test-branch-combine.cc b/test/cctest/compiler/test-branch-combine.cc

index 618404be5d36df3b1399071677db318e66d3f4db..58202a61b0977704c56e1ec5b7ff4ae676a33e32 100644

--- a/test/cctest/compiler/test-branch-combine.cc

+++ b/test/cctest/compiler/test-branch-combine.cc

@@ -415,7 +415,7 @@ TEST(BranchCombineInt32CmpAllInputShapes_inverse_branch_false) {

TEST(BranchCombineFloat64Compares) {

double inf = V8_INFINITY;

- double nan = v8::base::OS::nan_value();

+ double nan = std::numeric_limits<double>::quiet_NaN();

double inputs[] = {0.0, 1.0, -1.0, -inf, inf, nan};

int32_t eq_constant = -1733;