Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 774133003: Revert of create and thread batch tracker object (Closed)

Created:
6 years ago by joshualitt
Modified:
6 years ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@2_vertex_attr
Project:
skia
Visibility:
Public.

Description

Revert of create and thread batch tracker object (patchset #9 id:160001 of https://codereview.chromium.org/772513002/) Reason for revert: Breaking linux layout test Original issue's description: > create and thread batch tracker object > > I remove the factory on the next CL > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c3a6eb23483e5d28073b509a5f637f41660de294 TBR=bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/841a6b54c11137e210aa81e8b56e1763c3571cb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -339 lines) Patch
M include/gpu/GrBackendProcessorFactory.h View 3 chunks +9 lines, -23 lines 0 comments Download
M include/gpu/GrTBackendProcessorFactory.h View 2 chunks +19 lines, -67 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +4 lines, -11 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 2 chunks +3 lines, -10 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 2 chunks +0 lines, -33 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +9 lines, -27 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +20 lines, -50 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 8 chunks +15 lines, -37 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 10 chunks +13 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 4 chunks +11 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of create and thread batch tracker object
6 years ago (2014-12-04 13:59:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774133003/1
6 years ago (2014-12-04 14:00:26 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-04 14:00:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/841a6b54c11137e210aa81e8b56e1763c3571cb8

Powered by Google App Engine
This is Rietveld 408576698