Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 7647026: base: Add three helper functions to Values API. (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, vrk (LEFT CHROMIUM), jam, acolwell+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, ncarter (slow), idana, aboxhall+watch_chromium.org, Erik does not do reviews, ddorwin+watch_chromium.org, achuith+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, scherkus (not reviewing), tim (not reviewing), Avi (use Gerrit), kkania, fischman+watch_chromium.org, Raghu Simha, yuzo+watch_chromium.org, annacc+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hclam+watch_chromium.org, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, eroman, dtseng+watch_chromium.org, Paweł Hajdan Jr., mmenke
Visibility:
Public.

Description

base: Add three helper functions to Values API. Added three new helper functions to simplify the usage of the API by the clients. So now they are able to say: - base::NullValue() instead of base::Value::CreateNullValue(); - base::TrueValue() instead of base::Value::CreateBooleanValue(true); and new base::FundamentalValue(true); - base::FalseValue() instead of base::Value::CreateBooleanValue(false); and new base::FundamentalValue(false); Advantages: - This is shorter than the other forms, easy to read and much less verbose. BUG=None TEST=base_unittests --gtest_filter=Values* R=evan@chromium.org

Patch Set 1 #

Patch Set 2 : save many (vertical) lines #

Patch Set 3 : fix a typo Ceate -> Create #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -219 lines) Patch
M base/json/json_reader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/json/json_writer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/values.h View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
M base/values.cc View 1 2 10 chunks +29 lines, -15 lines 0 comments Download
M base/values_unittest.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_permissions_api.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_internals_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/cloud_policy_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 12 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_map_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/user_policy_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_model_associator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_set_observer_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 1 chunk +10 lines, -13 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncapi_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/js/js_arg_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync/sync_js_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc View 1 1 chunk +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/shell_dialogs_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals_ui_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/common_param_traits_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/json_pref_store_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/json_schema_validator_unittest_base.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M chrome/test/webdriver/commands/set_timeout_commands_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/session.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/web_element_id.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
content/renderer/render_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/v8_value_converter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/v8_value_converter_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/web_ui_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
ipc/ipc_message_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Hi Evan, please take a look. The interesting changes are in base/values.* The rest is ...
9 years, 4 months ago (2011-08-16 02:52:54 UTC) #1
tfarina
9 years, 4 months ago (2011-08-18 00:00:44 UTC) #2
Ping?

Powered by Google App Engine
This is Rietveld 408576698