chrome/common/json_pref_store_unittest.cc - Issue 7647026: base: Add three helper functions to Values API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/json_pref_store_unittest.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/json_pref_store_unittest.cc

diff --git a/chrome/common/json_pref_store_unittest.cc b/chrome/common/json_pref_store_unittest.cc

index 247aaf098a285e3784c25a65a889bd7d06bb1583..22458e660d9e76d4ae74a54390b4b918726bae02 100644

--- a/chrome/common/json_pref_store_unittest.cc

+++ b/chrome/common/json_pref_store_unittest.cc

@@ -125,8 +125,7 @@ void RunBasicJsonPrefStoreTest(JsonPrefStore *pref_store,

EXPECT_TRUE(actual->GetAsBoolean(&boolean));

EXPECT_TRUE(boolean);

- pref_store->SetValue(kNewWindowsInTabs,

- Value::CreateBooleanValue(false));

+ pref_store->SetValue(kNewWindowsInTabs, base::FalseValue());

EXPECT_EQ(PrefStore::READ_OK,

pref_store->GetValue(kNewWindowsInTabs, &actual));

EXPECT_TRUE(actual->GetAsBoolean(&boolean));