chrome/browser/extensions/extension_tabs_module.cc - Issue 7647026: base: Add three helper functions to Values API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tabs_module.cc

diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc

index a949b4df1de9d75d041314d9248999ed25cfe9b4..d2c8a0eb08e18365978c0dadc91f99a82e38e2e8 100644

--- a/chrome/browser/extensions/extension_tabs_module.cc

+++ b/chrome/browser/extensions/extension_tabs_module.cc

@@ -590,7 +590,7 @@ bool CreateWindowFunction::RunImpl() {

if (new_window->profile()->IsOffTheRecord() && !include_incognito()) {

// Don't expose incognito windows if the extension isn't allowed.

- result_.reset(Value::CreateNullValue());

+ result_.reset(base::NullValue());

} else {

result_.reset(ExtensionTabUtil::CreateWindowValue(new_window, true));

}