Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/prefs/pref_set_observer_unittest.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_set_observer_unittest.cc
diff --git a/chrome/browser/prefs/pref_set_observer_unittest.cc b/chrome/browser/prefs/pref_set_observer_unittest.cc
index c3f7a1265cd8419ad3e7ca7a1967afd66759a91e..1d5a4bf601e3e91fa5f2c9b02206a450c38ea860 100644
--- a/chrome/browser/prefs/pref_set_observer_unittest.cc
+++ b/chrome/browser/prefs/pref_set_observer_unittest.cc
@@ -53,7 +53,7 @@ TEST_F(PrefSetObserverTest, IsManaged) {
Value::CreateStringValue("http://crbug.com"));
EXPECT_TRUE(pref_set->IsManaged());
pref_service_->SetManagedPref(prefs::kHomePageIsNewTabPage,
- Value::CreateBooleanValue(true));
+ base::TrueValue());
EXPECT_TRUE(pref_set->IsManaged());
pref_service_->RemoveManagedPref(prefs::kHomePage);
EXPECT_TRUE(pref_set->IsManaged());
@@ -85,8 +85,7 @@ TEST_F(PrefSetObserverTest, Observe) {
Observe(int(chrome::NOTIFICATION_PREF_CHANGED),
Source<PrefService>(pref_service_.get()),
PrefNameDetails(prefs::kHomePageIsNewTabPage)));
- pref_service_->SetUserPref(prefs::kHomePageIsNewTabPage,
- Value::CreateBooleanValue(true));
+ pref_service_->SetUserPref(prefs::kHomePageIsNewTabPage, base::TrueValue());
Mock::VerifyAndClearExpectations(&observer);
EXPECT_CALL(observer, Observe(_, _, _)).Times(0);
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/search_engines/search_provider_install_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698