content/renderer/v8_value_converter_browsertest.cc - Issue 7647026: base: Add three helper functions to Values API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/v8_value_converter_browsertest.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/v8_value_converter_browsertest.cc

diff --git a/content/renderer/v8_value_converter_browsertest.cc b/content/renderer/v8_value_converter_browsertest.cc

index 7eed5f4d9efa25a9b56c19ab0e5a8c606ab313b4..afe6709002ba1878c0e52d08514a2448f68a9199 100644

--- a/content/renderer/v8_value_converter_browsertest.cc

+++ b/content/renderer/v8_value_converter_browsertest.cc

@@ -137,9 +137,9 @@ class V8ValueConverterTest : public testing::Test {

TEST_F(V8ValueConverterTest, BasicRoundTrip) {

DictionaryValue original_root;

- original_root.Set("null", Value::CreateNullValue());

- original_root.Set("true", Value::CreateBooleanValue(true));

- original_root.Set("false", Value::CreateBooleanValue(false));

+ original_root.Set("null", base::NullValue());

+ original_root.Set("true", base::TrueValue());

+ original_root.Set("false", base::FalseValue());

original_root.Set("positive-int", Value::CreateIntegerValue(42));

original_root.Set("negative-int", Value::CreateIntegerValue(-42));

original_root.Set("zero", Value::CreateIntegerValue(0));

« no previous file with comments | « content/renderer/v8_value_converter.cc ('k') | content/renderer/web_ui_bindings.cc » ('j') | no next file with comments »