chrome/test/webdriver/commands/set_timeout_commands_unittest.cc - Issue 7647026: base: Add three helper functions to Values API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

diff --git a/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc b/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

index a4e84b3d7d0df93b6bf7182523f816d5b2f30803..56ebc0009da2c9c2fad6d42ceed671eee19830e1 100644

--- a/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

+++ b/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

@@ -68,7 +68,7 @@ TEST(ImplicitWaitCommandTest, SettingImplicitWaits) {

AssertError(kBadRequest, "Request missing ms parameter", &command);

- parameters->Set("ms", Value::CreateNullValue());

+ parameters->Set("ms", base::NullValue());

AssertError(kBadRequest, "ms parameter is not a number", &command);

parameters->SetString("ms", "apples");