base: Add three helper functions to Values API.

chrome/browser/extensions/extension_input_ime_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_input_ime_api.h"
 
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/input_method/input_method_engine.h"
 #include "chrome/browser/extensions/extension_event_router.h"
@@ skipping 284 matching lines @@
   }
   return NULL;
 }
 
 bool SetCompositionFunction::RunImpl() {
   chromeos::InputMethodEngine* engine =
       ExtensionInputImeEventRouter::GetInstance()->
           GetActiveEngine(extension_id());
   if (!engine) {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(false));
+      result_.reset(base::FalseValue());
     }
     return true;
   }
 
   DictionaryValue* args;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &args));
   int context_id;
   std::string text;
   int selection_start;
   int selection_end;
@@ skipping 38 matching lines @@
       segments.back().style =
           chromeos::InputMethodEngine::SEGMENT_STYLE_DOUBLE_UNDERLINE;
     }
   }
 
   std::string error;
 
   if (engine->SetComposition(context_id, text.c_str(), selection_start,
                              selection_end, segments, &error)) {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(true));
+      result_.reset(base::TrueValue());
     }
     return true;
   } else {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(false));
+      result_.reset(base::FalseValue());
     }
     return false;
   }
 }
 
 bool ClearCompositionFunction::RunImpl() {
   chromeos::InputMethodEngine* engine =
       ExtensionInputImeEventRouter::GetInstance()->
           GetActiveEngine(extension_id());
   if (!engine) {
     return false;
   }
 
   DictionaryValue* args;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &args));
   int context_id;
 
   EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kContextIdKey,
                                                &context_id));
 
   std::string error;
   if (engine->ClearComposition(context_id, &error)) {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(true));
+      result_.reset(base::TrueValue());
     }
     return true;
   } else {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(false));
+      result_.reset(base::FalseValue());
     }
     return false;
   }
 }
 
 bool CommitTextFunction::RunImpl() {
   // TODO(zork): Support committing when not active.
   chromeos::InputMethodEngine* engine =
       ExtensionInputImeEventRouter::GetInstance()->
           GetActiveEngine(extension_id());
   if (!engine) {
     return false;
   }
 
   DictionaryValue* args;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &args));
   int context_id;
   std::string text;
 
   EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kContextIdKey,
                                                      &context_id));
   EXTENSION_FUNCTION_VALIDATE(args->GetString(keys::kTextKey, &text));
 
   std::string error;
   if (engine->CommitText(context_id, text.c_str(), &error)) {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(true));
+      result_.reset(base::TrueValue());
     }
     return true;
   } else {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(false));
+      result_.reset(base::FalseValue());
     }
     return false;
   }
 }
 
 bool SetCandidateWindowPropertiesFunction::RunImpl() {
   DictionaryValue* args;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &args));
 
   std::string engine_id;
@@ skipping 51 matching lines @@
 
   if (properties->HasKey(keys::kAuxiliaryTextVisibleKey)) {
     bool visible;
     EXTENSION_FUNCTION_VALIDATE(properties->GetBoolean(
         keys::kAuxiliaryTextVisibleKey,
         &visible));
     engine->SetCandidateWindowAuxTextVisible(visible);
   }
 
   if (has_callback()) {
-    result_.reset(Value::CreateBooleanValue(true));
+    result_.reset(base::TrueValue());
   }
 
   return true;
 }
 
 #if defined(OS_CHROMEOS)
 bool SetCandidatesFunction::ReadCandidates(
     ListValue* candidates,
     std::vector<chromeos::InputMethodEngine::Candidate>* output) {
   for (size_t i = 0; i < candidates->GetSize(); ++i) {
@@ skipping 58 matching lines @@
   ListValue* candidate_list;
   EXTENSION_FUNCTION_VALIDATE(args->GetList(keys::kCandidatesKey,
                                             &candidate_list));
   if (!ReadCandidates(candidate_list, &candidates)) {
     return false;
   }
 
   std::string error;
   if (engine->SetCandidates(context_id, candidates, &error)) {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(true));
+      result_.reset(base::TrueValue());
     }
     return true;
   } else {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(false));
+      result_.reset(base::FalseValue());
     }
     return false;
   }
 }
 
 bool SetCursorPositionFunction::RunImpl() {
   chromeos::InputMethodEngine* engine =
       ExtensionInputImeEventRouter::GetInstance()->
           GetActiveEngine(extension_id());
   if (!engine) {
     return false;
   }
 
   DictionaryValue* args;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &args));
   int context_id;
   int candidate_id;
 
   EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kContextIdKey,
                                                      &context_id));
   EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kCandidateIdKey,
                                                      &candidate_id));
 
   std::string error;
   if (engine->SetCursorPosition(context_id, candidate_id, &error)) {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(true));
+      result_.reset(base::TrueValue());
     }
     return true;
   } else {
     if (has_callback()) {
-      result_.reset(Value::CreateBooleanValue(false));
+      result_.reset(base::FalseValue());
     }
     return false;
   }
   return true;
 }
 
 bool SetMenuItemsFunction::RunImpl() {
   // TODO
   return true;
 }
 
 bool UpdateMenuItemsFunction::RunImpl() {
   // TODO
   return true;
 }
 #endif