chrome/browser/extensions/extension_webnavigation_api.cc - Issue 7647026: base: Add three helper functions to Values API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webnavigation_api.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webnavigation_api.cc

diff --git a/chrome/browser/extensions/extension_webnavigation_api.cc b/chrome/browser/extensions/extension_webnavigation_api.cc

index 4a6a9a92d1dc48f8cf6a3be4937a38339e8cba64..8da72c4556fefabbab7108c1aecf10e68db78d96 100644

--- a/chrome/browser/extensions/extension_webnavigation_api.cc

+++ b/chrome/browser/extensions/extension_webnavigation_api.cc

@@ -599,7 +599,7 @@ bool GetFrameFunction::RunImpl() {

EXTENSION_FUNCTION_VALIDATE(

details->GetInteger(keys::kFrameIdKey, &frame_id));

- result_.reset(Value::CreateNullValue());

+ result_.reset(base::NullValue());

TabContentsWrapper* wrapper;

if (!ExtensionTabUtil::GetTabById(