Reland: Move TouchSelectionController from content to ui

Reland: Move TouchSelectionController from content to ui

This patch is only moving new unified touch selection files from
content/ to ui/touch_selection/. This is the first step to allow Aura
use the new unified TouchSelectionController.

The only change to TouchSelectionController needed for this move is
replacing use of cc::ViewportSelectionBound with ui::SelectionBound.

The actual use of the new touch selection for Aura will happen in future
CL(s). After that, we can remove current touch selection code from
ui/base/touch/.

BUG=399721
Committed: https://crrev.com/29fd405ca491a6fcf0dde6277d92d44300cb2926
Cr-Commit-Position: refs/heads/master@{#307336}

Committed: https://crrev.com/f837da7c7807d4dc84733b201ac74a6bab9ae3a5
Cr-Commit-Position: refs/heads/master@{#307514}

[mohsen, 2014-11-25 05:45:13]

Patchset #2 (id:20001) has been deleted

[mohsen, 2014-11-26 22:38:56]

Patchset #4 (id:80001) has been deleted

[mohsen, 2014-11-26 23:06:11]

Patchset #4 (id:100001) has been deleted

[mohsen, 2014-11-27 16:49:23]

Patchset #5 (id:140001) has been deleted

[mohsen, 2014-11-27 17:48:51]

Patchset #5 (id:160001) has been deleted

[mohsen, 2014-11-27 18:46:15]

Patchset #5 (id:180001) has been deleted

[mohsen, 2014-11-27 23:39:26]

mohsen@chromium.org changed reviewers:
+ jdduke@chromium.org, mfomitchev@chromium.org

[mohsen, 2014-11-27 23:39:28]

Please take a look...

jdduke@: can you especially take a look at android gyp/gn files, please?

[jdduke (slow), 2014-12-01 20:38:04]

At a high level, the move looks good. I don't love the idea of a new directory
just for touch_selection, but maybe that's the easiest way to make it usable in
content/ on Android and also with Aura?

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
File ui/base/touch/selection_bound.cc (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.cc:38: SetEdgeTop(bound.edge_top);
Let's skip these setters if the bound is empty, as this will be called every
frame.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.cc:72: b1.edge_top_rounded().x(),
Hmm, it may not be any better, but what about:

gfx::Point p0(b1.edge_top_rounded());
p0.SetToMin(b1.edge_bottom_rounded());
p0.SetToMin(b2.edge_top_rounded()):
p0.SetToMin(b2.edge_top_rounded());

gfx::Point p1(...);
p1.SetToMax(...);
...

return gfx::Rect(p0, p1 - p0);

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
File ui/touch_selection/touch_selection_controller.cc (right):

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
ui/touch_selection/touch_selection_controller.cc:62: start_orientation_ =
ToTouchHandleOrientation(start_.type());
I know I had a good reason for caching this, but I don't remember what it was,
and now it just looks redundant... hmm, I guess we can keep for now.

[mfomitchev, 2014-12-01 21:36:24]

+1 to jdduke's comment re new touch_selection folder. It seems to me
ui/base/touch/ would be a better place for the new files.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
File ui/base/touch/selection_bound.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:8: #include
"cc/output/viewport_selection_bound.h"
A bunch of these can simply be declared here and included in the .cc file
instead.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:36: void SetEdgeTop(const gfx::PointF& value);
Might be better to simply have SetEdge(top, bottom)? We usually set top and
bottom together.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:45: int GetHeight() const;
GetHeightRounded() for consistency?

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
File ui/base/touch/selection_bound_unittest.cc (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound_unittest.cc:7: #include
"testing/gtest/include/gtest/gtest.h"
Adjust --similarity so that it detects that this is a rename of
touch_editing_controller_unittest.cc?

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/touch_edi...
File ui/base/touch/touch_editing_controller.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/touch_edi...
ui/base/touch/touch_editing_controller.h:9: #include
"ui/base/touch/selection_bound.h"
Declare class here and move include to cc?

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/DEPS
File ui/touch_selection/DEPS (right):

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/DEPS...
ui/touch_selection/DEPS:1: include_rules = [
And here it thinks we are modifying an existing file which we are not..

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
File ui/touch_selection/touch_selection_controller.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
ui/touch_selection/touch_selection_controller.h:12: #include
"ui/touch_selection/touch_handle.h"
We only need to import selection_bound.h, not all off touch_handle.h?

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
ui/touch_selection/touch_selection_controller.h:16: 
I think the convention is no blank line in spots like this.

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/ui_t...
File ui/touch_selection/ui_touch_selection_export.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/ui_t...
ui/touch_selection/ui_touch_selection_export.h:9: // accelerometer module can be
exported to consumers.
comment needs updating

https://codereview.chromium.org/759433002/diff/200001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.h:20: #include
"ui/base/touch/selection_bound.h"
Can move include to cc.

[mohsen, 2014-12-02 03:45:05]

Patchset #7 (id:240001) has been deleted

[mohsen, 2014-12-02 03:47:46]

Patchset #7 (id:260001) has been deleted

[mohsen, 2014-12-02 03:58:15]

Patchset #7 (id:280001) has been deleted

[mohsen, 2014-12-02 03:58:23]

Patchset #6 (id:220001) has been deleted

[mohsen, 2014-12-02 04:02:20]

Patchset #6 (id:300001) has been deleted

[mohsen, 2014-12-02 04:25:19]

Patchset #6 (id:320001) has been deleted

[mohsen, 2014-12-02 04:45:13]

Patchset #6 (id:340001) has been deleted

[mohsen, 2014-12-02 04:51:26]

Patchset #6 (id:360001) has been deleted

[mohsen, 2014-12-02 05:17:03]

If we want to move touch selection to ui, I think we should either put it in
ui/base/ or in a new directory in ui/ (like what I did). I feel touch selection
controller is not that "basic" to be appropriate for ui/base/ and decided to put
it in ui/touch_selection/ based on sadrul@'s suggestion as a ui/ owner.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
File ui/base/touch/selection_bound.cc (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.cc:38: SetEdgeTop(bound.edge_top);
On 2014/12/01 20:38:04, jdduke wrote:
> Let's skip these setters if the bound is empty, as this will be called every
> frame.

Done.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.cc:72: b1.edge_top_rounded().x(),
On 2014/12/01 20:38:04, jdduke wrote:
> Hmm, it may not be any better, but what about:
> 
> gfx::Point p0(b1.edge_top_rounded());
> p0.SetToMin(b1.edge_bottom_rounded());
> p0.SetToMin(b2.edge_top_rounded()):
> p0.SetToMin(b2.edge_top_rounded());
> 
> gfx::Point p1(...);
> p1.SetToMax(...);
> ...
> 
> return gfx::Rect(p0, p1 - p0);

Done, although, I wish we could do this:
return gfx::UnionRects(
    gfx::BoundingRect(b1.edge_top_rounded(), b1.edge_bottom_rounded()),
    gfx::BoundingRect(b2.edge_top_rounded(), b2.edge_bottom_rounded()));

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
File ui/base/touch/selection_bound.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:8: #include
"cc/output/viewport_selection_bound.h"
On 2014/12/01 21:36:24, mfomitchev wrote:
> A bunch of these can simply be declared here and included in the .cc file
> instead.

Done.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:36: void SetEdgeTop(const gfx::PointF& value);
On 2014/12/01 21:36:24, mfomitchev wrote:
> Might be better to simply have SetEdge(top, bottom)? We usually set top and
> bottom together.

Yeah. Added SetEdge(). (at least SetEdgeTop() is still useful)

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:45: int GetHeight() const;
On 2014/12/01 21:36:24, mfomitchev wrote:
> GetHeightRounded() for consistency?

Since this is kind of temporary and would go away after unification, I thought
it's not worth it to change the name (and update all call sites, and also rename
RectBetweenSelectionBounds()).

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
File ui/base/touch/selection_bound_unittest.cc (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/selection...
ui/base/touch/selection_bound_unittest.cc:7: #include
"testing/gtest/include/gtest/gtest.h"
On 2014/12/01 21:36:24, mfomitchev wrote:
> Adjust --similarity so that it detects that this is a rename of
> touch_editing_controller_unittest.cc?

Done.

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/touch_edi...
File ui/base/touch/touch_editing_controller.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/base/touch/touch_edi...
ui/base/touch/touch_editing_controller.h:9: #include
"ui/base/touch/selection_bound.h"
On 2014/12/01 21:36:24, mfomitchev wrote:
> Declare class here and move include to cc?

Done.

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/DEPS
File ui/touch_selection/DEPS (right):

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/DEPS...
ui/touch_selection/DEPS:1: include_rules = [
On 2014/12/01 21:36:24, mfomitchev wrote:
> And here it thinks we are modifying an existing file which we are not..

Done.

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
File ui/touch_selection/touch_selection_controller.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
ui/touch_selection/touch_selection_controller.h:12: #include
"ui/touch_selection/touch_handle.h"
On 2014/12/01 21:36:24, mfomitchev wrote:
> We only need to import selection_bound.h, not all off touch_handle.h?

We're using a lot from touch_handle.h (e.g. subclassing TouchHandleClient,
TouchHandleOrientation, TouchHandle::AnimationStyle).

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/touc...
ui/touch_selection/touch_selection_controller.h:16: 
On 2014/12/01 21:36:24, mfomitchev wrote:
> I think the convention is no blank line in spots like this.

Done.

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/ui_t...
File ui/touch_selection/ui_touch_selection_export.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/touch_selection/ui_t...
ui/touch_selection/ui_touch_selection_export.h:9: // accelerometer module can be
exported to consumers.
On 2014/12/01 21:36:24, mfomitchev wrote:
> comment needs updating

Done.

https://codereview.chromium.org/759433002/diff/200001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/759433002/diff/200001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.h:20: #include
"ui/base/touch/selection_bound.h"
On 2014/12/01 21:36:24, mfomitchev wrote:
> Can move include to cc.

Done.

[mfomitchev, 2014-12-02 16:07:27]

LGTM

[jdduke (slow), 2014-12-02 16:35:35]

jdduke@chromium.org changed reviewers:
+ sadrul@chromium.org

[jdduke (slow), 2014-12-02 16:35:37]

I have a slight preference to putting things in ui/base/touch, but it's not a
deal breaker.

sadrul@: Just confirming that you'd prefer the additional touch_selection folder
in ui/? I don't have a strong opinion, only that adding a new base folder adds a
bit of overhead (albeit hopefully one-time overhead).

Assuming that's how you'd like it, content/browser/android and
content/browser/renderer_host/input lgtm.

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/selection...
File ui/base/touch/selection_bound.h (right):

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:34: explicit SelectionBound(const
cc::ViewportSelectionBound& bound);
Why is this virtual?

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:53: int GetHeight() const;
Hmm, this might be worth a comment, as this could mean either the difference
between the rounded top/bottom, or the rounded difference between top/bottom,
and they're not the same.

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/touch_edi...
File ui/base/touch/touch_editing_controller.h (right):

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/touch_edi...
ui/base/touch/touch_editing_controller.h:5: #ifndef
UI_BASE_TOUCH_TOUCH_EDITING_CONTROLLER_H_
I guess it's a little confusing why we have TouchEditingController in
ui/base/touch, but not TouchSelectionController?

https://codereview.chromium.org/759433002/diff/380001/ui/touch_selection/DEPS
File ui/touch_selection/DEPS (right):

https://codereview.chromium.org/759433002/diff/380001/ui/touch_selection/DEPS...
ui/touch_selection/DEPS:2: "+ui/base",
Can you add an OWNERS file to this directory and include me?

https://codereview.chromium.org/759433002/diff/380001/ui/touch_selection/ui_t...
File ui/touch_selection/ui_touch_selection.gyp (right):

https://codereview.chromium.org/759433002/diff/380001/ui/touch_selection/ui_t...
ui/touch_selection/ui_touch_selection.gyp:36: 'target_name':
'ui_touch_selection_unittests',
Don't you need to explicitly add |ui_touch_selection_unittests| to a global test
harness to make sure they're run by default?

[mohsen, 2014-12-02 20:50:31]

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/selection...
File ui/base/touch/selection_bound.h (right):

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:34: explicit SelectionBound(const
cc::ViewportSelectionBound& bound);
On 2014/12/02 16:35:37, jdduke wrote:
> Why is this virtual?

virtual removed.

https://codereview.chromium.org/759433002/diff/380001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:53: int GetHeight() const;
On 2014/12/02 16:35:36, jdduke wrote:
> Hmm, this might be worth a comment, as this could mean either the difference
> between the rounded top/bottom, or the rounded difference between top/bottom,
> and they're not the same.

Done.

https://codereview.chromium.org/759433002/diff/380001/ui/touch_selection/DEPS
File ui/touch_selection/DEPS (right):

https://codereview.chromium.org/759433002/diff/380001/ui/touch_selection/DEPS...
ui/touch_selection/DEPS:2: "+ui/base",
On 2014/12/02 16:35:37, jdduke wrote:
> Can you add an OWNERS file to this directory and include me?

Done.

[mfomitchev, 2014-12-02 20:56:15]

https://codereview.chromium.org/759433002/diff/400001/ui/base/touch/selection...
File ui/base/touch/selection_bound.h (right):

https://codereview.chromium.org/759433002/diff/400001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:53: // Retruns the difference between rounded
top y and rounded bottom y.
typo

[jdduke (slow), 2014-12-02 21:07:15]

https://codereview.chromium.org/759433002/diff/400001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/759433002/diff/400001/build/all.gyp#newcode841
build/all.gyp:841: '../ui/events/events.gyp:events_unittests',
Don't we need to add the touch_selection unittests here? Basically everywhere
there's events_unittests I would think? Though maybe we should hold off until we
get the final word from sadrul@ as to whether we really want a separate logical
namespace here.

[mohsen, 2014-12-02 21:14:04]

https://codereview.chromium.org/759433002/diff/400001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/759433002/diff/400001/build/all.gyp#newcode841
build/all.gyp:841: '../ui/events/events.gyp:events_unittests',
On 2014/12/02 21:07:15, jdduke wrote:
> Don't we need to add the touch_selection unittests here? Basically everywhere
> there's events_unittests I would think? Though maybe we should hold off until
we
> get the final word from sadrul@ as to whether we really want a separate
logical
> namespace here.

Yep, I'll probably need to add it here and some other places. But, I'm waiting
for sadrul@'s comment on touch_selection directory.

https://codereview.chromium.org/759433002/diff/400001/ui/base/touch/selection...
File ui/base/touch/selection_bound.h (right):

https://codereview.chromium.org/759433002/diff/400001/ui/base/touch/selection...
ui/base/touch/selection_bound.h:53: // Retruns the difference between rounded
top y and rounded bottom y.
On 2014/12/02 20:56:15, mfomitchev wrote:
> typo

Oops! This is not even my final wording for the comment!

[sadrul, 2014-12-03 00:00:28]

On 2014/12/02 16:35:37, jdduke wrote:
> I have a slight preference to putting things in ui/base/touch, but it's not a
> deal breaker.
> 
> sadrul@: Just confirming that you'd prefer the additional touch_selection
folder
> in ui/? I don't have a strong opinion, only that adding a new base folder adds
a
> bit of overhead (albeit hopefully one-time overhead).

I prefer touch_selection to be a separate component, and not bundled into
ui_base (which includes all code in //ui/base/). So //ui/touch_selection/ makes
sense, yes.

mohsen@: Can you please clarify in the CL description that views textfield
doesn't switch to the new touch-selection controller yet with this CL, and it
will happen in a future CL? Having touch_editing_controller in //ui/base/touch/
and touch_selection_controller in //ui/touch_selection/ is going to be
confusing. Will the relevant code in //ui/base/touch/ be removed? Can you
clarify that in the CL description too?

[mohsen, 2014-12-04 18:48:13]

Patchset #9 (id:440001) has been deleted

[mohsen, 2014-12-04 18:55:09]

Patchset #9 (id:460001) has been deleted

[mohsen, 2014-12-04 18:59:19]

Patchset #9 (id:480001) has been deleted

[mohsen, 2014-12-04 19:12:25]

Patchset #9 (id:500001) has been deleted

[mohsen, 2014-12-04 21:45:24]

I've updated CL description and fixed gyp files for tests.

sadrul@: can you take a look, please?

[sadrul, 2014-12-04 21:47:49]

lgtm

[jdduke (slow), 2014-12-04 21:49:37]

Sigh, still not in love with the top-level churn this is causing, per offline
discussion we'll need to add the tests to
build/android/pylib/gtest/gtest_config.py.

[mohsen, 2014-12-04 22:43:39]

mohsen@chromium.org changed reviewers:
+ boliu@chromium.org

[mohsen, 2014-12-04 22:43:40]

+boliu@ for OWNERS review of /android_webview/

+jam@ for OWNERS review of /content/, specifically, /content/DEPS,
/content/content.gyp, /content/browser/BUILD.gn, and
/content/public/android/BUILD.gn and also the top-level /BUILD.gn

[mohsen, 2014-12-04 22:44:32]

mohsen@chromium.org changed reviewers:
+ jam@chromium.org

[mohsen, 2014-12-04 22:44:33]

+jam@ for OWNERS review of /content/, specifically, /content/DEPS,
/content/content.gyp, /content/browser/BUILD.gn, and
/content/public/android/BUILD.gn and also the top-level /BUILD.gn

[boliu, 2014-12-04 23:10:56]

android_webview lgtm

[jam, 2014-12-05 00:31:55]

lgtm

[mohsen, 2014-12-05 04:44:46]

Patchset #11 (id:560001) has been deleted

[mohsen, 2014-12-08 19:52:50]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-12-08 19:53:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/759433002/580001

[commit-bot: I haz the power, 2014-12-08 20:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-08 20:01:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mohsen, 2014-12-08 20:04:14]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-12-08 20:05:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/759433002/600001

[commit-bot: I haz the power, 2014-12-08 21:06:56]

Committed patchset #12 (id:600001)

[commit-bot: I haz the power, 2014-12-08 21:08:10]

Patchset 12 (id:??) landed as
https://crrev.com/29fd405ca491a6fcf0dde6277d92d44300cb2926
Cr-Commit-Position: refs/heads/master@{#307336}

[Ryan Sleevi, 2014-12-08 21:50:40]

A revert of this CL (patchset #12 id:600001) has been created in
https://codereview.chromium.org/754963007/ by rsleevi@chromium.org.

The reason for reverting is: Suspected of causing Win8 GN failure

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/1552/steps...

FAILED: ninja -t msvc -e environment.x86 --
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/ui/base/dragdrop/ui_base_unittests.os_exchange_data_provider_aurax11_unittest.obj.rsp
/c ../../ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc
/Foobj/ui/base/dragdrop/ui_base_unittests.os_exchange_data_provider_aurax11_unittest.obj
/Fdobj/ui/base/ui_base_unittests_cc.pdb
c:\b\build\slave\win8_gn\build\src\ui\base\dragdrop\os_exchange_data_provider_aurax11.h(8)
: fatalerror C1083: Cannot open include file: 'X11/Xlib.h': No such file or
directory
.

[mohsen, 2014-12-09 17:51:32]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-12-09 17:52:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/759433002/620001

[mohsen, 2014-12-09 18:12:04]

The CQ bit was unchecked by mohsen@chromium.org

[mohsen, 2014-12-09 18:59:35]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-12-09 18:59:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/759433002/620001

[commit-bot: I haz the power, 2014-12-09 19:01:45]

Committed patchset #13 (id:620001)

[commit-bot: I haz the power, 2014-12-09 19:02:39]

Patchset 13 (id:??) landed as
https://crrev.com/f837da7c7807d4dc84733b201ac74a6bab9ae3a5
Cr-Commit-Position: refs/heads/master@{#307514}