Reland: Move TouchSelectionController from content to ui

ui/base/touch/selection_bound.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_BASE_TOUCH_SELECTION_BOUND_H_
+#define UI_BASE_TOUCH_SELECTION_BOUND_H_
+
+#include "cc/output/viewport_selection_bound.h"

[mfomitchev, 2014/12/01 21:36:24]

A bunch of these can simply be declared here and included in the .cc file
instead.

[mohsen, 2014/12/02 05:17:02]

Done.

+#include "ui/base/ui_base_export.h"
+#include "ui/gfx/point.h"
+#include "ui/gfx/point_f.h"
+#include "ui/gfx/rect.h"
+
+namespace ui {
+
+// Bound of a selection end-point.
+class UI_BASE_EXPORT SelectionBound {
+ public:
+  enum Type {
+    LEFT,
+    RIGHT,
+    CENTER,
+    EMPTY,
+    LAST = EMPTY
+  };
+
+  SelectionBound();
+  SelectionBound(const cc::ViewportSelectionBound& bound);
+  virtual ~SelectionBound();
+
+  Type type() const { return type_; }
+  void set_type(Type value) { type_ = value; }
+
+  const gfx::PointF& edge_top() const { return edge_top_; }
+  const gfx::Point& edge_top_rounded() const { return edge_top_rounded_; }
+  void SetEdgeTop(const gfx::PointF& value);

[mfomitchev, 2014/12/01 21:36:24]

Might be better to simply have SetEdge(top, bottom)? We usually set top and
bottom together.

[mohsen, 2014/12/02 05:17:02]

Yeah. Added SetEdge(). (at least SetEdgeTop() is still useful)

+
+  const gfx::PointF& edge_bottom() const { return edge_bottom_; }
+  const gfx::Point& edge_bottom_rounded() const { return edge_bottom_rounded_; }
+  void SetEdgeBottom(const gfx::PointF& value);
+
+  bool visible() const { return visible_; }
+  void set_visible(bool value) { visible_ = value; }
+
+  int GetHeight() const;

[mfomitchev, 2014/12/01 21:36:24]

GetHeightRounded() for consistency?

[mohsen, 2014/12/02 05:17:02]

Since this is kind of temporary and would go away after unification, I thought
it's not worth it to change the name (and update all call sites, and also rename
RectBetweenSelectionBounds()).

+
+ private:
+  Type type_;
+  gfx::PointF edge_top_;
+  gfx::PointF edge_bottom_;
+  gfx::Point edge_top_rounded_;
+  gfx::Point edge_bottom_rounded_;
+  bool visible_;
+};
+
+UI_BASE_EXPORT bool operator==(const SelectionBound& lhs,
+                               const SelectionBound& rhs);
+UI_BASE_EXPORT bool operator!=(const SelectionBound& lhs,
+                               const SelectionBound& rhs);
+
+UI_BASE_EXPORT gfx::Rect RectBetweenSelectionBounds(const SelectionBound& b1,
+                                                    const SelectionBound& b2);
+
+}  // namespace ui
+
+#endif  // UI_BASE_TOUCH_SELECTION_BOUND_H_