Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 759433002: Reland: Move TouchSelectionController from content to ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Excluded ui/touch_selection from Windows GN build Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 7bed6a0cf85fc56f9d163f8c1e10424c7d5e315e..1e6789004a2639f31b1b55a2cacb5115763466e9 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -45,7 +45,6 @@
#include "content/browser/renderer_host/compositor_impl_android.h"
#include "content/browser/renderer_host/dip_util.h"
#include "content/browser/renderer_host/input/synthetic_gesture_target_android.h"
-#include "content/browser/renderer_host/input/touch_selection_controller.h"
#include "content/browser/renderer_host/input/web_input_event_builders_android.h"
#include "content/browser/renderer_host/input/web_input_event_util.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
@@ -81,6 +80,7 @@
#include "ui/gfx/geometry/dip_util.h"
#include "ui/gfx/screen.h"
#include "ui/gfx/size_conversions.h"
+#include "ui/touch_selection/touch_selection_controller.h"
namespace content {
@@ -257,14 +257,14 @@ ui::LatencyInfo CreateLatencyInfo(const blink::WebInputEvent& event) {
return latency_info;
}
-scoped_ptr<TouchSelectionController> CreateSelectionController(
- TouchSelectionControllerClient* client,
+scoped_ptr<ui::TouchSelectionController> CreateSelectionController(
+ ui::TouchSelectionControllerClient* client,
ContentViewCore* content_view_core) {
DCHECK(client);
DCHECK(content_view_core);
int tap_timeout_ms = gfx::ViewConfiguration::GetTapTimeoutInMs();
int touch_slop_pixels = gfx::ViewConfiguration::GetTouchSlopInPixels();
- return make_scoped_ptr(new TouchSelectionController(
+ return make_scoped_ptr(new ui::TouchSelectionController(
client,
base::TimeDelta::FromMilliseconds(tap_timeout_ms),
touch_slop_pixels / content_view_core->GetDpiScale()));
@@ -1245,24 +1245,25 @@ void RenderWidgetHostViewAndroid::SelectBetweenCoordinates(
}
void RenderWidgetHostViewAndroid::OnSelectionEvent(
- SelectionEventType event,
+ ui::SelectionEventType event,
const gfx::PointF& position) {
DCHECK(content_view_core_);
// Showing the selection action bar can alter the current View coordinates in
// such a way that the current MotionEvent stream is suddenly shifted in
// space. Avoid the associated scroll jump by pre-emptively cancelling gesture
// detection; scrolling after the selection is activated is unnecessary.
- if (event == SelectionEventType::SELECTION_SHOWN)
+ if (event == ui::SelectionEventType::SELECTION_SHOWN)
ResetGestureDetection();
content_view_core_->OnSelectionEvent(event, position);
}
-scoped_ptr<TouchHandleDrawable> RenderWidgetHostViewAndroid::CreateDrawable() {
+scoped_ptr<ui::TouchHandleDrawable>
+RenderWidgetHostViewAndroid::CreateDrawable() {
DCHECK(content_view_core_);
if (!using_browser_compositor_)
return content_view_core_->CreatePopupTouchHandleDrawable();
- return scoped_ptr<TouchHandleDrawable>(new CompositedTouchHandleDrawable(
+ return scoped_ptr<ui::TouchHandleDrawable>(new CompositedTouchHandleDrawable(
content_view_core_->GetLayer().get(),
content_view_core_->GetDpiScale(),
// Use the activity context (instead of the application context) to ensure
@@ -1316,7 +1317,8 @@ void RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(
if (selection_controller_) {
selection_controller_->OnSelectionBoundsChanged(
- frame_metadata.selection_start, frame_metadata.selection_end);
+ ui::SelectionBound(frame_metadata.selection_start),
+ ui::SelectionBound(frame_metadata.selection_end));
}
// All offsets and sizes are in CSS pixels.
@@ -1627,11 +1629,10 @@ void RenderWidgetHostViewAndroid::OnShowingPastePopup(
// of the region have been updated, explicitly set the properties now.
// TODO(jdduke): Remove this workaround when auxiliary paste popup
// notifications are no longer required, crbug.com/398170.
- cc::ViewportSelectionBound insertion_bound;
- insertion_bound.type = cc::SELECTION_BOUND_CENTER;
- insertion_bound.visible = true;
- insertion_bound.edge_top = point;
- insertion_bound.edge_bottom = point;
+ ui::SelectionBound insertion_bound;
+ insertion_bound.set_type(ui::SelectionBound::CENTER);
+ insertion_bound.set_visible(true);
+ insertion_bound.SetEdge(point, point);
selection_controller_->HideAndDisallowShowingAutomatically();
selection_controller_->OnSelectionEditable(true);
selection_controller_->OnSelectionEmpty(true);

Powered by Google App Engine
This is Rietveld 408576698