Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed)

Created:
6 years, 1 month ago by Elliot Glaysher
Modified:
6 years, 1 month ago
Reviewers:
jamesr, sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Rebuild aura::Window's property system on top of mojo::View. BUG=431047 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ca8bb9dc588b303aff41d5d84e38913d058f92ae

Patch Set 1 #

Patch Set 2 : The rest of the sky comments from the previous review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -76 lines) Patch
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 4 chunks +41 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_unittest.cc View 5 chunks +172 lines, -30 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view.h View 1 4 chunks +55 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_observer.h View 1 chunk +20 lines, -4 lines 0 comments Download
A mojo/services/public/cpp/view_manager/view_property.h View 1 chunk +140 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/server_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/server_view_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_apptest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Elliot Glaysher
This splits the local view property stuff out of the other patch, and for clarity, ...
6 years, 1 month ago (2014-11-17 21:08:47 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-11-17 21:39:35 UTC) #3
Elliot Glaysher
Committed patchset #2 (id:20001) manually as ca8bb9dc588b303aff41d5d84e38913d058f92ae (presubmit successful).
6 years, 1 month ago (2014-11-17 21:45:37 UTC) #4
jamesr
6 years, 1 month ago (2014-11-17 22:02:50 UTC) #6
Message was sent while issue was closed.
I think this broke the build:

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/mojo/services/view_manager/view_manager_service_unittests.view_coordinate_conversions_unittest.o.d
-DCHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1
-DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
-DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_GLIB=1 -DUSE_NSS=1 -DUSE_X11=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1
-DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1
-DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DCR_CLANG_REVISION=218707
-D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DGL_GLEXT_PROTOTYPES -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0
-DGTEST_HAS_RTTI=0 -DSK_SUPPORT_LEGACY_TEXTRENDERMODE
-DSK_IGNORE_GPU_LAYER_HOISTING -DSK_ENABLE_INST_COUNT=0
-DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
-DMOJO_USE_SYSTEM_IMPL -DUNIT_TEST -I../.. -Igen -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos
-I../../gpu -Igen/ui/gl -I../../testing/gtest/include -I../../skia/config
-I../../skia/ext -I../../third_party/skia/include/c
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/images
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/src/core -I../../third_party/skia/src/image
-I../../third_party/skia/src/opts -I../../third_party/skia/src/ports
-I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils
-I../../third_party/skia/src/lazy -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n -fno-strict-aliasing -fstack-protector
--param=ssp-buffer-size=4 -m64 -march=x86-64 -funwind-tables -fPIC -pipe
-pthread -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
-Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion
-fno-ident -fdata-sections -ffunction-sections -O2 -g0 -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c
../../mojo/services/view_manager/view_coordinate_conversions_unittest.cc -o
obj/mojo/services/view_manager/view_manager_service_unittests.view_coordinate_conversions_unittest.o
../../mojo/services/view_manager/view_coordinate_conversions_unittest.cc:40:68:
error: only virtual member functions can be marked 'override'
                             const std::vector<uint8_t>* new_data) override {}
                                                                   ^~~~~~~~~

Powered by Google App Engine
This is Rietveld 408576698