mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc - Issue 732223002: Rebuild aura::Window's property system on top of mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: The rest of the sky comments from the previous review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h ('k') | mojo/services/public/cpp/view_manager/tests/view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

index 9421e180ed388d1ab0f0bcdbd4652c91d80d3d40..e70ec2bda312cb1a0fd95ce49870f8c182e0d473 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

@@ -341,7 +341,7 @@ void ViewManagerClientImpl::OnViewDrawnStateChanged(Id view_id, bool drawn) {

ViewPrivate(view).LocalSetDrawn(drawn);

}

-void ViewManagerClientImpl::OnViewPropertyChanged(

+void ViewManagerClientImpl::OnViewSharedPropertyChanged(

Id view_id,

const String& name,

Array<uint8_t> new_data) {

@@ -354,7 +354,7 @@ void ViewManagerClientImpl::OnViewPropertyChanged(

data_ptr = &data;

}

- view->SetProperty(name, data_ptr);

+ view->SetSharedProperty(name, data_ptr);

}