mojo/services/view_manager/server_view.cc - Issue 732223002: Rebuild aura::Window's property system on top of mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/server_view.cc

Issue 732223002: Rebuild aura::Window's property system on top of mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: The rest of the sky comments from the previous review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/server_view.cc

diff --git a/mojo/services/view_manager/server_view.cc b/mojo/services/view_manager/server_view.cc

index 3bb9e64e9f1ae1e8de26b62a1bf1273769121ba5..937f43705b9aacd0260f62fb5341168e5cb4c296 100644

--- a/mojo/services/view_manager/server_view.cc

+++ b/mojo/services/view_manager/server_view.cc

@@ -139,7 +139,7 @@ void ServerView::SetProperty(const std::string& name,

properties_.erase(it);

}

- delegate_->OnViewPropertyChanged(this, name, value);

+ delegate_->OnViewSharedPropertyChanged(this, name, value);

}

bool ServerView::IsDrawn(const ServerView* root) const {